UI: Clarify indexer seed time and client torrent preservation settings for My Anonamouse - #129
Open
jberlyn wants to merge 1 commit into
Open
UI: Clarify indexer seed time and client torrent preservation settings for My Anonamouse#129jberlyn wants to merge 1 commit into
jberlyn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The previous indexer settings and localization strings led to confusion regarding how seeding limits and torrent preservation operate between Chaptarr and download clients (e.g., qBittorrent, rTorrent):
NeverMoveOnImport): The label suggested Chaptarr would force the download client to seed indefinitely. In reality, this setting controls Chaptarr's file import and cleanup lifecycle—ensuring files are copied/hardlinked rather than moved, and preventing Chaptarr from automatically removing completed torrents/data from the download client (exempting them from the "Remove Completed Downloads" task). It does not override or manage the download client's own seeding/ratio limits.SeedTimeHours): The help text stated that MAM requires 72 hours, but did not make clear that configuring a value passes a stopping limit directly to the download client (stopping seeding once 72 hours is reached), nor that leaving it blank allows the torrent to follow the download client's default seeding rules.Change summary
MyAnonaMouseSettings.cs): Updated to explicitly state that the value is the time before the client stops seeding, and that leaving it blank uses the download client's default seeding rules.en.json): Renamed"Keep seeding permanently"(IndexerSettingsNeverMoveOnImport) to"Preserve torrents in client"and clarified that it always copies/hardlinks on import and prevents removal without overriding client-side limits.en.json,RTorrent.cs,DownloadImportModeResolver.cs): Synchronized existing references (ConvertMp3ToM4bHelpText,ConvertToQualityHelpText,RemoveCompletedDownloadsHelpText, and provider/resolver log messages) to use the new"Preserve torrents in client"naming.Testing summary
MyAnonaMouseSettingsValidatorandSeedCriteriaSettingsValidatorrules remain unchanged and allow null/emptySeedTimeHourswithout warnings.NeverMoveOnImport,SeedTimeHours) are preserved so database configurations and API contracts remain unaffected.