Skip to content

fix: validate node name components before SPARQL substitution #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoundMatt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate node name components before SPARQL substitution #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cdsp/knowledge-layer/connector/json-rdf-convertor/rdf-writer/src/triple_assembler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <iostream>
#include <nlohmann/json.hpp>
#include <regex>
#include <sstream>

#include "data_message.h"
Expand Down Expand Up @@ -204,6 +205,17 @@ void TripleAssembler::generateTriplesFromNode(const Node& node, const SchemaType
// Split node data point into object and data elements
const auto [object_elements, data_element] = extractObjectsAndDataElements(node.getName());

// Validate each component against an identifier pattern to guard against SPARQL injection
static const std::regex valid_id{R"([A-Za-z][A-Za-z0-9_]*)"};
for (const auto& elem : object_elements) {
if (!std::regex_match(elem, valid_id)) {
throw std::runtime_error("Invalid node name component: " + elem);
}
}
if (!std::regex_match(data_element, valid_id)) {
throw std::runtime_error("Invalid node name component: " + data_element);
}

const auto queries = model_config_->getQueriesTripleAssemblerHelper().getQueries();
TripleAssemblerHelper::QueryPair query_pair;
if (queries.find(msg_schema_type) != queries.end()) {
Expand Down