fix: validate node name components before SPARQL substitution#113
Open
SoundMatt wants to merge 1 commit into
Open
fix: validate node name components before SPARQL substitution#113SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
Node name components from WebSocket messages were substituted directly into SPARQL query templates via replaceAllQueryVariables without any validation, allowing a malicious or MITM WebSocket server to inject arbitrary SPARQL. Add a regex guard that rejects any component not matching [A-Za-z][A-Za-z0-9_]* with a runtime_error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Node name components derived from incoming WebSocket messages are substituted directly into SPARQL query templates via
replaceAllQueryVariableswithout any sanitisation. A malicious or MITM WebSocket server can craft a node name containing SPARQL metacharacters to inject arbitrary query logic.Root cause
extractObjectsAndDataElementssplits the raw node name on.and returns the parts as plain strings. These parts are then used as-is to replace%A%and%B%placeholders in query templates. There is no check that the components are valid identifiers before substitution.Fix
After
extractObjectsAndDataElementsreturns, validate every component (both object elements and the data element) against the pattern[A-Za-z][A-Za-z0-9_]*. If any component fails the check, throwstd::runtime_errorbefore any query substitution occurs. Add<regex>to the include list.