feature: PR 3/8 — SettingsContext and SCSS theming - #700
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
feature: PR 3/8 — SettingsContext and SCSS theming#700devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 3 of 8 (stacked on #699). Replaces
SettingsServicewith a React context and brings the SCSS theme layer into the React tree.src/app/andsrc/styles.scssare untouched — Angular still builds from them.src/react/context/SettingsContext.tsx—SettingsProvider+useSettings(). Same localStorage keys (theme,openLinkInNewTab,titleFontSize,listSpacing), same defaults ('16'/'0'), same string types, same write-through-on-set behavior, and the sameprefers-color-schemehandling: use the stored theme if present, otherwisematches ? 'night' : 'default'(read directly instead of Angular's syntheticMediaQueryListEventdispatch).useEffectand torn down with the same function reference. The Angular service passed a fresh.bind(this)toremoveEventListener, so its listener was never actually removed; not reproduced.localStorage/matchMediaaccess is guarded so the module can't throw where they're unavailable.sassadded as a devDependency;styles.scssand the three partials copied tosrc/react/byte-identically except the partial import path, and imported frommain.tsx. Sass prints legacy@import/slash-division/darken()deprecation warnings inherited from the original files.vite.config.ts: the entry-injectingtransformIndexHtmlhook now runs withorder: 'pre', otherwise the injected module script isn't part of the build graph and the SCSS never reaches the output.Apptemporarily appliessettings.themeas its wrapper className; PR 4 replaces it with the real shell.Verified:
npm run typecheck:react,npx vite build(built CSS contains.default/.night/.amoledblack), andvitedev server boots clean.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/e6419ebe67ff4f749fe1573a8e26cd07
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review