feature: PR 4/8 — routes, App shell, Header/Footer/Settings - #701
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 4 of 8 (stacked on #700). Ports
app.routes.ts,app.component.*andsrc/app/core/*to React.Feed,ItemDetailsandUserare placeholders here — PRs 5-7 fill them in. Nothing undersrc/app/changes.src/react/routes.tsxmirrors the Angular route table, withAppas the layout route supplying<Outlet/>in place ofrouter-outlet:feedNameis passed as a prop rather than re-derived from the URL, so the five feeds stay exhaustive overFeedName.ItemDetails/UserareReact.lazyand build into their own chunks, preserving Angular's lazy modules.Appreproducesapp.component.htmlexactly (themewrapper →body-cover→wrapper→Header/Outlet/Footer) and portsapp.component.scss.usePageViews()hook: auseEffectonpathnamethat firesga('set','page')+ga('send','pageview')only when theindex.htmlsnippet actually definedga. Isolated in one file so it's trivial to drop.HeaderusesNavLink; Angular'srouterLinkActivewas non-exact, so any page of a feed must mark it active.NavLink'sisActivealone only matches/news/1, so activity is also derived from the first path segment —/news/2still highlights news.Settingspopup ported with controlled inputs. Angular fired(keyup)on the number inputs;onChangeis used instead, which additionally catches spinner clicks. Values stay strings,minattributes preserved.h1,.content,.active,.popup) are now app-wide — worth keeping in mind for later PRs.Verified:
npm run typecheck:react,npx vite build(separate lazy chunks emitted), and dev-server route checks for/→/news/1,/news/2,/ask/1,/item/123,/user/pgwith a clean console.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/e6419ebe67ff4f749fe1573a8e26cd07
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review