feature: PR 2/8 — models, Promise-based HN API and comment util - #699
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of 8 (stacked on #698). Framework-agnostic foundations under
src/react/; nothing undersrc/app/is touched.src/react/models/*— the six Angular models ported verbatim (hencestrictPropertyInitialization: falsein the React tsconfig, since the originals are classes with uninitialized fields).src/react/utils/comments.ts—formatComments(count)replacesCommentPipe, same output (discuss/1 comment/N comments).src/react/api/hackernews.ts— replacesHackerNewsAPIService: RxJSObservable+unfetchbecome platformfetch+ Promises.Two deliberate deviations from the Angular service:
lazyFetchresolved on any response, so a 500 surfaced as a JSON parse failure or an empty feed; the sharedgetJsonhelper throws on!res.oksoFeed/ItemDetailscan renderErrorMessage.fetchItemContentawaits the poll fetches instead of returning early:The Angular version returned the story while
subscribecallbacks mutatedpollafterwards — fine with Angular change detection, unreliable with React state.Also note
FeedType('poll' | 'story' | 'job') is the item type, not the route name, so feed names get their ownFeedNametype used byfetchFeedand, later, the routes.Verified:
npm run typecheck:react,npx vite build, plus a livefetchFeed('news', 1)call returning 30 stories.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/e6419ebe67ff4f749fe1573a8e26cd07
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review