feature: PR 1/8 — React + Vite scaffolding alongside Angular - #698
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
feature: PR 1/8 — React + Vite scaffolding alongside Angular#698devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Co-Authored-By: Paul Abboud <abboudpaul112@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of 8 PRs migrating this Angular 9 HN PWA to React. This one only stands React up next to Angular — no Angular code, config, or dependency is touched, so nothing regresses.
vite.config.tswithroot: 'src', sosrc/index.html,src/assets,src/manifest.jsonandsrc/favicon.icoresolve unchanged.src/index.htmlgains only<div id="root">next to<app-root>. The<script type="module" src="/main.tsx">tag is not committed to the HTML — Angular CLI processesindex.htmland chokes on a.tsxmodule script — so a tiny VitetransformIndexHtmlplugin injects it at dev/build time instead.src/main.tsxmounts a placeholderAppinsideBrowserRouter; React sources live insrc/react/to avoid colliding with Angular'ssrc/app/.start,build) are untouched; React getsdev,build:react,typecheck:react.Angular is pinned to
typescript@~3.7.5, which cannot parse modernreact-router-domtype declarations. Rather than hand-writing a shim module (which would need extending in every later PR and would mask real type errors), a second compiler is installed side-by-side via an npm alias and used only for the React config:Verified:
npx vite buildandnpm run typecheck:reactboth pass.Note:
npm run build(Angular) fails on Node 20 witherror:0308010C:digital envelope routines::unsupported— a pre-existing Node/OpenSSL incompatibility of the Angular 9 Webpack toolchain, present onmasterbefore this branch and unaffected by it.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/e6419ebe67ff4f749fe1573a8e26cd07
Requested by: @abboudp
Note
Devin errored when opening this Pull Request as abboudp.
As a fallback, Devin opened this PR as itself.
Devin Review