Skip to content

added dev container and fixed (too many returns) of isBuffer() smell in serialize.ts #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jtthani wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added dev container and fixed (too many returns) of isBuffer() smell in serialize.ts #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"name": "TypeScript project",
"image": "oven/bun:1.3.14",
"postCreateCommand":"apt-get update && apt-get install -y git python3 build-essential && bun install"
}
15 changes: 7 additions & 8 deletions packages/app/src/addons/serialize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,13 @@ const isRecord = (value: unknown): value is Record<string, unknown> => {
}

const isBuffer = (value: unknown): value is IBuffer => {
if (!isRecord(value)) return false
if (typeof value.length !== "number") return false
if (typeof value.cursorX !== "number") return false
if (typeof value.cursorY !== "number") return false
if (typeof value.baseY !== "number") return false
if (typeof value.viewportY !== "number") return false
if (typeof value.getLine !== "function") return false
if (typeof value.getNullCell !== "function") return false
if ((!isRecord(value)) || (typeof value.length !== "number")
|| (typeof value.cursorX !== "number")
|| (typeof value.cursorY !== "number")
|| (typeof value.baseY !== "number")
|| (typeof value.viewportY !== "number")
|| (typeof value.getLine !== "function")
|| (typeof value.getNullCell !== "function")) return false
return true
}

Expand Down
Loading