feat: add vault colour and type design tokens #99
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| :root { | ||
| --vault-surface-card: #ffffff; | ||
| --vault-surface-inset: #f7f7f7; | ||
| --vault-surface-page: #efefef; | ||
| --vault-fill-warn: var(--vault-surface-page); | ||
| --vault-border-faint: #f2f2f2; | ||
|
Comment on lines
+2
to
+6
Member
Author
There was a problem hiding this comment. Correct, the count was wrong. There are fifteen colour tokens over fourteen distinct values: Keeping the alias. The warn fill and the page surface are the same grey today but answer to different reasons, so a rebrand should be able to move one without the other. The description now says what the numbers are. |
||
| --vault-border-hairline: #e0e0e0; | ||
| --vault-border-inactive: #b4b4b4; | ||
| --vault-text-muted: #6e6e6e; | ||
| --vault-text-body: #2e2e2e; | ||
| --vault-ink: #000000; | ||
| --vault-action: #1d4ed8; | ||
| --vault-action-ring: #edf2fe; | ||
| --vault-success: #1f7a4c; | ||
| --vault-success-fill: #ebf4ef; | ||
| --vault-danger: #b3261e; | ||
| --vault-font-sans: "Space Grotesk", system-ui, sans-serif; | ||
| --vault-font-mono: "JetBrains Mono", ui-monospace, monospace; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| .vaultName { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 700; | ||
| font-size: 30px; | ||
| line-height: 1.05; | ||
| letter-spacing: -0.02em; | ||
| } | ||
|
|
||
| .cardHead { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 500; | ||
| font-size: 21px; | ||
| line-height: 1.2; | ||
| } | ||
|
|
||
| .waitHead { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 500; | ||
| font-size: 19px; | ||
| line-height: 1.25; | ||
| } | ||
|
|
||
| .sectionHead { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 500; | ||
| font-size: 18px; | ||
| line-height: 1.25; | ||
| } | ||
|
|
||
| .body { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 400; | ||
| font-size: 16px; | ||
| line-height: 1.5; | ||
| } | ||
|
|
||
| .stepTitle { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 500; | ||
| font-size: 15.5px; | ||
| line-height: 1.3; | ||
| } | ||
|
|
||
| .footnote { | ||
| font-family: var(--vault-font-sans); | ||
| font-weight: 400; | ||
| font-size: 13.5px; | ||
| line-height: 1.5; | ||
| } | ||
|
|
||
| .label { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 500; | ||
| font-size: 11px; | ||
| line-height: 1; | ||
| letter-spacing: 0.12em; | ||
| text-transform: uppercase; | ||
| } | ||
|
|
||
| .position { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 500; | ||
| font-size: 28px; | ||
| line-height: 1.05; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .metric { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 500; | ||
| font-size: 25px; | ||
| line-height: 1.05; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .amountInput { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 400; | ||
| font-size: 25px; | ||
| line-height: 1.1; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .estimate { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 500; | ||
| font-size: 22px; | ||
| line-height: 1.15; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .summaryValue { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 400; | ||
| font-size: 15px; | ||
| line-height: 1.4; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .railValue { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 400; | ||
| font-size: 13.5px; | ||
| line-height: 1.4; | ||
| font-variant-numeric: tabular-nums; | ||
| } | ||
|
|
||
| .metricSub { | ||
| font-family: var(--vault-font-mono); | ||
| font-weight: 400; | ||
| font-size: 12.5px; | ||
| line-height: 1.3; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A custom property cannot be read inside a media query condition, so a breakpoint token would never be usable. Verified in a browser: at 1200px wide,
@media (min-width: var(--bp))did not apply while@media (min-width: 600px)did.The criterion asking for breakpoints was the problem, not its absence here. It has been dropped from #98, and each component writes its own media query.