feat: add vault colour and type design tokens - #99
Open
luchobonatti wants to merge 2 commits into
Open
Conversation
Define the LP Vault's 14 colour custom properties and 15 type role classes read from the design prototype, so components built for #83 reach for a token instead of a literal hex code or font block.
There was a problem hiding this comment.
🟡 Changes recommended
The acceptance criteria call for breakpoint tokens and 14 colors, but the diff adds no breakpoint tokens and currently defines 15 semantic color variables (including an alias).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds centralized vault design tokens (colors + typography) to reduce repeated hex/font declarations across vault UI primitives and support rebranding from a single source.
Changes:
- Introduces
:rootCSS custom properties for vault color + font tokens. - Adds a CSS module with 15 typography role classes that reference the new font tokens.
- Loads Space Grotesk + JetBrains Mono via Google Fonts and wires the token sheet into the app entrypoint.
File summaries
| File | Description |
|---|---|
| app/src/styles/type.module.css | Adds typography role classes (sans + mono) intended for reuse across vault components. |
| app/src/styles/tokens.css | Defines vault CSS variables for semantic color roles and font families. |
| app/src/main.tsx | Imports the new token stylesheet so variables are available at runtime. |
| app/index.html | Extends the Google Fonts request to include Space Grotesk and JetBrains Mono. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+4
| :root { | ||
| --vault-surface-card: #ffffff; | ||
| --vault-surface-inset: #f7f7f7; | ||
| --vault-surface-page: #efefef; |
Comment on lines
+2
to
+6
| --vault-surface-card: #ffffff; | ||
| --vault-surface-inset: #f7f7f7; | ||
| --vault-surface-page: #efefef; | ||
| --vault-fill-warn: var(--vault-surface-page); | ||
| --vault-border-faint: #f2f2f2; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #98
The components in #83 share one palette and two type families. Without a single place holding them, each stylesheet repeats the same hex values and rebranding a white-label instance means editing all of them.
Changes
Acceptance criteria
Test plan
No component consumes these yet, so nothing exercises them at runtime.
Automated tests
npm run test— 8 passing, unchanged. This slice adds none.npm run build --workspaces --if-present— passes.Manual verification
npm run dev, open the app, and confirm in devtools that:rootcarries the--vault-*properties.Breaking changes
None.
Checklist
Screenshots
None.