Skip to content

windows: remove unused String methods from console types - #55

Open
Sebastiaan van Stijn (thaJeztah) wants to merge 2 commits into
Azure:masterfrom
thaJeztah:remove_stringers
Open

Sebastiaan van Stijn (thaJeztah) wants to merge 2 commits into
Azure:masterfrom
thaJeztah:remove_stringers

Conversation

@thaJeztah

Copy link
Copy Markdown
Contributor

Remove the unused String methods from CONSOLE_SCREEN_BUFFER_INFO, COORD, and SMALL_RECT. These methods were introduced in the initial commit (go-ansiterm@8b62c38), apparently for debugging purposes, but are not used by the package itself and I was not able to find any external uses that depended on this.

This makes the types identical to their counterparts in golang.org/x/sys/windows, allowing them to be replaced with type aliases and subsequently deprecated.

Remove the unused String methods from CONSOLE_SCREEN_BUFFER_INFO, COORD,
and SMALL_RECT. These methods were introduced in the initial commit
([go-ansiterm@8b62c38]), apparently for debugging purposes, but are not
used by the package itself and I was not able to find any external uses
that depended on this.

This makes the types identical to their counterparts in golang.org/x/sys/windows,
allowing them to be replaced with type aliases and subsequently deprecated.

[go-ansiterm@8b62c38]: Azure@8b62c38

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah Sebastiaan van Stijn (thaJeztah) changed the title winterm: remove stringer implementation windows: remove unused String methods from console types Oct 13, 2026
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant