Skip to content

chore: migrate to @github/keytar #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjinks merged 1 commit into from
Jun 18, 2026
Merged

chore: migrate to @github/keytar #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpers/build-sea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ function buildBundle() {
format: 'cjs',
outfile: bundlePath,
external: [
'@postman/node-keytar',
'@postman/node-keytar/*',
'@github/keytar',
'@github/keytar/*',
Comment on lines 85 to +87
'cpu-features',
'cpu-features/*',
'lando',
Expand Down
206 changes: 22 additions & 184 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,13 @@
"xml2js": "^0.6.2"
},
"optionalDependencies": {
"@postman/node-keytar": "~7.9.3"
"@github/keytar": "^7.10.6"
},
"publishConfig": {
"access": "public"
},
"allowScripts": {
"ssh2@1.17.0": true,
"@github/keytar@7.10.6": true
Comment on lines +186 to +188
}
}
2 changes: 1 addition & 1 deletion src/lib/keychain/secure.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import keytar from '@postman/node-keytar';
import keytar from '@github/keytar';

import type { Keychain } from './keychain';

Expand Down
2 changes: 1 addition & 1 deletion types/@postman/node-keytar/index.d.ts → types/@github/keytar/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
declare module '@postman/node-keytar' {
declare module '@github/keytar' {
interface KeytarModule {
getPassword( service: string, account: string ): Promise< string | null >;
setPassword( service: string, account: string, password: string ): Promise< void >;
Expand Down