chore: migrate to @github/keytar#2892
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
rebeccahum
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the CLI’s secure keychain integration from the deprecated @postman/node-keytar package to @github/keytar, updating runtime imports and the project’s dependency/packaging configuration accordingly.
Changes:
- Switched secure keychain implementation to import
@github/keytar. - Updated dependency metadata and lockfile to use
@github/keytar, and added anallowScriptsentry for its install script. - Updated SEA bundling externals to treat
@github/keytaras an external native dependency.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| types/@postman/node-keytar/index.d.ts | Removes the local TS module declaration for the old keytar package. |
| src/lib/keychain/secure.ts | Updates keytar import to @github/keytar. |
| package.json | Replaces optional dependency and adds allowScripts allow-list entries. |
| npm-shrinkwrap.json | Updates shrinkwrap to resolve @github/keytar and removes old dependency tree. |
| helpers/build-sea.js | Updates SEA bundling externals from @postman/node-keytar to @github/keytar. |
Files not reviewed (1)
- npm-shrinkwrap.json: Generated file
Comment on lines
+186
to
+188
| "allowScripts": { | ||
| "ssh2@1.17.0": true, | ||
| "@github/keytar@7.10.6": true |
Comment on lines
85
to
+87
| external: [ | ||
| '@postman/node-keytar', | ||
| '@postman/node-keytar/*', | ||
| '@github/keytar', | ||
| '@github/keytar/*', |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate from unsupported
@postman/node-keytarto@github/keytar.Pull request checklist
New release checklist
Steps to Test
CI must pass.