Skip to content

Fix Windows interface freeze and save-on-close deadlock (v0.2.1) - #3

Merged
AronAxe merged 1 commit into
mainfrom
fix/windows-native-freeze-v0.2.1
Oct 6, 2026
Merged

AronAxe merged 1 commit into
mainfrom
fix/windows-native-freeze-v0.2.1

Conversation

@AronAxe

@AronAxe AronAxe commented Oct 6, 2026

Copy link
Copy Markdown
Owner

User-reported fault

The packaged app opened but became unresponsive when interacting with the native window. Earlier HTTP/startup and Chromium tests did not exercise the Windows bridge.

Root causes and fixes

  • DesktopBridge exposed its store, runner and native Window as public attributes. pywebview recursively reflected the native WinForms/COM object graph, producing recursion-limit and wrong-thread WebView2 errors. All backing state is now private, enforced by slots; only four explicit RPC methods are exposed.
  • The synchronous FormClosing callback waited for JavaScript while blocking the UI thread. It now returns immediately and dispatches the save handshake on a worker. Declined prompts or failed saves reset the handshake; pending draft edits are preserved.
  • Added a real Windows regression that sends native mouse messages and exercises the actual compiled window, bridge promises, Connections, a native Save As dialog, and save-before-close. The Windows release workflow now requires this test before artifact publication.
  • Corrected a browser test race so it waits for settings-save completion before asserting persistence.

Verified on native Windows 11

  • 126 automated tests passed; 1 symlink-permission test skipped.
  • 26 browser workflow checks passed, zero page errors.
  • 9 native-window checks passed from source.
  • 9 native-window checks passed against the actual compiled executable, with zero page errors, no recursive bridge errors, normal process exit, and verified persistence of the pending manuscript.
  • Compiled backend/bundled-assets test passed; official Codex runtime preserved.
  • ZIP: GraphPaper-v0.2.1-Windows-x64.zip, 157,603,152 bytes.
  • SHA-256: 988cd93b4a1a1f7a4f849de800ea385a0dcc528c69a667f81a0c728f46e357b4.

Reports are under docs/validation/v0.2.1. Testing used isolated temporary projects, not the user's manuscript database or credentials. No live model/OAuth request was made. The strict CSP is unchanged. This is a corrective release; the 0.2 author-voice, project-folder, humanizer/deslop and Codex features are retained.

@AronAxe
AronAxe merged commit d71a8da into main Oct 6, 2026
5 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T14:29:41.753036Z 5a8b262 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d71a8da000

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread graphpaper/__init__.py
@@ -1,2 +1,2 @@
"""GraphPaper: an evidence-aware, graph-native writing studio."""
__version__ = "0.2.0"
__version__ = "0.2.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the displayed client version in sync

When this 0.2.1 build is launched, ui/app.js:68 still displays “GraphPaper · 0.2.0”, while graphpaper/codex.py:73 also identifies the Codex client as version 0.2.0. Users installing this corrective release therefore cannot verify from the application that the Windows fix is present, and provider diagnostics report the wrong release; update these values or derive them from the authoritative package version.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant