Repository navigation
fix: parse single-line fenced LLM replies in skill generator - #45
Merged
Merged
Conversation
generate_skill() strips markdown fences with text.index("\n"), which raises
ValueError when the model returns the skill in a single-line fence or a bare
"```". Use find() and fall back to dropping just the three backticks, mirroring
the fix already applied to the paper-pilot client and parameter optimizer.
Adds parametrized regression tests for the single-line, bare and empty-block
cases.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（小 bug 修复 + 回归测试）
改动：
skills/generator.py的generate_skill()用text.index("\n")剥离 markdown 围栏，当模型把内容放在单行围栏（…）或只回一个 ``` 时抛ValueError。改为 `find()`，无换行时只去掉三个反引号——与 #20（parameter_optimizer）、#44（paper_pilot_client）的修法一致。新增 3 个参数化回归用例（单行围栏 / 裸围栏 / 空围栏块），修复前 2 个失败、修复后全过。测试：通过（本地 `tests/test_skill_generator.py` 10 passed；全量 pytest 见 CI）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code