Repository navigation
fix: parse single-line fenced LLM replies in measurement decider - #51
Merged
Merged
Conversation
decide_measurement stripped markdown fences with text.index("\n"), which
raises ValueError when the model returns the JSON on a single fenced line
(```{...}``` or ```json{...}```). Use find() with a fallback that drops the
backticks and an optional language tag, so such replies parse normally and
genuinely malformed ones still degrade to the rule-based decision. Same
pattern already applied to the paper-pilot client, skill generator,
analyzer and classifier; this is the last remaining instance.
Regression tests live in a new file so they do not collide with the
pending decider test suite.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动维护改动
类型：维护（小 bug 修复 + 回归测试）
改动：
orchestrator/decider.decide_measurement剥离 markdown 围栏时用text.index("\n")，模型把 JSON 放在单行围栏内（{...}/json{...}）会抛ValueError；改为find()加回退（去掉反引号与可选的json语言标签），并新增tests/test_decider_fences.py6 个回归用例（修复前 3 个失败 / 修复后全过）。与 #44/#45/#46/#47 同类，是最后一处。测试放在独立文件，避免与待处理的 #37 冲突。测试：通过（本地全量 528 passed，ruff check / format 全过）
参考：无
本 PR 由每日维护任务生成，请人工 review 后再合并。
🤖 Generated with Claude Code