Repository navigation
Conversation
Nine tool stubs exposed through `altimate tool run` (dbt_run_results, dbt_defer_state, dbt_map_relations, docs_share_comments, dbt_cost_estimate, dbt_health, dbt_sql_graph, dbt_docs_coverage, dbt_cte_profile), an exported `AltimateApi.apiRequest` that calls the backend with the stored credentials, and `dbtAdapterFor`, the one gate every adapter-backed tool goes through: it refuses read-only calls, other projects, and an adapter that did not start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Review loop result: approvedTwo independent reviewers (Claude and Codex) each reviewed the whole PR against
Checks: |
|
Demo recording: /Users/harish/.quikim/artifacts/pu-mods/videos/F.mp4 (with the asciinema cast F.cast beside it, 82 s). It shows, in order: |
|
CI note: TypeScript tests show 21131 pass and 1 fail on each of three runs. The failing test differs each time, and each is a 200 ms wall-clock performance limit: lint grandfathered-suffix rescan at 225 ms, redaction shell-command boundaries at 255 ms, redaction plain text at 216 ms. This PR changes no lint or redaction code. |
|
Confirm-gate review of 1eb722e..21d0494 (claude -p and codex exec): claude APPROVED, codex APPROVED. One new [MINOR] test-strength note, review-loop: APPROVED at 21d0494 |
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Findings already raised by other bots on this PR are not repeated here. This incremental pass found no new defects in the follow-up commits; the three items below were re-verified against current Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Previous Review Summary (commit 21d0494)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 21d0494)Status: 4 Issues Found | Recommendation: Address before merge Overview
Findings already raised by other bots on this PR are not repeated here. Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (13 files)
Reviewed by deepseek-v4.1-flash-1017 · Input: 68.4K · Output: 16K · Cached: 922.1K Review guidance: REVIEW.md from base branch |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
…abort before a read-only refusal - apiRequest sends any body but undefined (null, false, 0 and "" were dropped) and takes an optional signal that cancels the request along with its 15 s timeout. - dbtAdapterFor throws for a cancelled call before it would refuse a read-only or plan-mode one. - Tests cover these and a session inside the adapter's own project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at d8c3469 Verify-only gate on 21d0494..d8c3469 (fixes for the cubic and Kilo review threads): Claude APPROVED, Codex APPROVED. Non-blocking MINOR follow-ups:
|
Issue for this PR
Closes #
Type of change
What does this PR do?
Lays the groundwork for the dbt Power User features. Separate follow-up PRs fill in each tool.
toolCLI allow-list:dbt_cost_estimate,dbt_cte_profile,dbt_defer_state,dbt_docs_coverage,dbt_health,dbt_map_relations,dbt_run_results,dbt_sql_graph,docs_share_comments. Each one is a stub with its final parameter schema. For now, running it returnssuccess: falseand the message "not implemented in this build", so callers can wire against the final names and shapes already.dbt-adapter-access.ts, the shared helper the tools will use to reach the dbt project and adapter.apiRequest()to the Altimate API client. It sends an authenticated call with the stored Bearer key and thex-tenantheaders. When credentials are missing or can't be read, the error names the credentials file instead of failing with a generic message.Changelog
altimate-code tool list. They are not implemented yet and report that when run.How did you verify your code works?
bun typecheckinpackages/opencodepasses with no errors.test/altimate/dbt-adapter-access.test.tscovers the adapter-access helper.Cost side effects
None. The new tools are stubs and make no model calls, warehouse queries or cloud requests.
apiRequestonly sends a request when a later tool calls it.Screenshots / recordings
Checklist
Demo video
Demo video (hosted)
F.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code
Summary by cubic
Lays the groundwork for the dbt Power User tools: nine tools are now registered in the
toolCLI allow-list with their final parameter schemas, and each returns "not implemented in this build" when run, so follow-up PRs can build each one without changing its name or shape.dbtAdapterFor(dbt-adapter-access.ts), the shared gate every adapter-backed tool goes through. It refuses read-only and plan-mode calls, sessions outside the adapter's dbt project, and adapters that don't start or load, with a bounded start wait that follows the call's abort signal; a call cancelled before the refusal check throws instead of answering.AltimateApi.apiRequest(), which sends an authenticated request with the stored Bearer key andx-tenantheaders, names the credentials file when credentials are missing or unreadable, sends any body exceptundefined(falsy JSON values are no longer dropped), and follows the caller's abort signal alongside its 15 s timeout.Written for commit d8c3469. Summary will update on new commits.