Repository navigation
Conversation
Each feature gets its own file under hooks/features/, called by name from features/index.ts in a fixed order: its own hooks, the session and turn events, its band line and its tool-call phases. One tool.call hook (tool-chain.ts) runs Bash and file handling in fixed phases: bashRewrite, bashGate, the call, bashAfter, editAfter, readOrEditAfter. The status line is built from parts (status-line.ts). runTool moves to altimate-cli.ts with a `write` option that goes through the CLI with --allow-write. dbt-command.ts finds the dbt invocations in a shell command line. New userConfig fields: maxScanBytes, healthBlocksPush, healthConfigPath, commentsPollSeconds, commentsInContext. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Subshells after keywords, case patterns, process substitution, arrays, arithmetic and function definitions parse again; quotes in a heredoc inside a substitution are text; a function or case pattern named dbt is not an invocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review loop result: approvedThree independent reviewer runs looked at this PR: Claude (approve, confidence 0.8), a second Claude pass on the parser, and Codex. A separate run then checked each round of fixes. Replies to every finding: Round 1 (fixed in 4328fc3)
Fix check on round 1 (fixed in 6f6c89e)
Second fix check (passed). Its follow-ups:
Checks: |
|
Demo recording: /Users/harish/.quikim/artifacts/pu-mods/videos/F.mp4 (with the asciinema cast F.cast beside it, 82 s). It shows, in order: |
readable() also returns null rather than false when a line cannot be read, matching its declared type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Confirm-gate review of 4328fc3..6f6c89e (claude -p and codex exec, both REQUEST CHANGES). Replies:
Plugin tests: 212 pass, 0 fail. |
|
Confirm-gate r2 at 2b31340: claude APPROVED, codex REQUEST CHANGES.
|
Skip a here-string's <<< as one operator instead of refusing any << after a <, so \<<<EOF still opens a heredoc whose body is read as text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Confirm-gate r3 on 2b31340..b36cbe6: fixed in b36cbe6, the r2 finding (
|
|
review-loop: APPROVED at b36cbe6 |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Checked this increment against the earlier findings: the invocation offsets now start at the assignment/launcher after any prefix words (verified for Previous Review Summary (commit b36cbe6)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit b36cbe6)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (20 files)
Also verified while reviewing: the Reviewed by deepseek-v4.1-flash-1017 · Input: 83.7K · Output: 26.8K · Cached: 994.6K |
…sion, chain wiring tested - parseDbtCommand's start leaves out the shell keywords and prefix commands in front of dbt (if, then, !, time, nohup, env and its options) and keeps the assignments right before it, so a rewrite spliced between start and end keeps the line valid shell. - The status parts are cleared at session start, so an earlier session's part is not drawn again. - runTool's write option documents that the caller must have the user's yes first. - A test asserts the plugin registers the tool chain's hook and that it runs the call it is given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
review-loop: APPROVED at f681699 Verify-only gate on b36cbe6..f681699 (fixes for the Kilo review threads): Claude APPROVED, Codex APPROVED. Non-blocking MINOR follow-ups:
|
What does this PR do?
Sets up the plugin side of the dbt Power User features. Separate follow-up PRs fill in each feature.
hooks/tool-chain.ts): one ordered pipeline around every tool call. A Bash call goes through bashRewrite, bashGate, the call, then bashAfter. An edit runs editAfter and readOrEditAfter, and a read runs readOrEditAfter. When a gate denies a call, nothing after it runs. A failed or refused call runs no file phases.hooks/features/*): nine feature modules (cost, cte-profile, defer, docs, health, runs, sql-graph, to-model, comments), registered in a fixed order infeatures/index.ts. Each one is a stub for now, so a call passes through unchanged.hooks/dbt-command.ts) and analtimate-cli.tshelper that runs altimate-codetoolcommands.hooks/status-line.ts): joins the features' parts in their fixed order.integrations.tsx. Lineage behavior is unchanged, and the existing lineage tests pass.plugin.jsonuserConfigadds these settings:maxScanBytes,healthBlocksPush,healthConfigPath,commentsPollSeconds,commentsInContext.This depends on the altimate-code tools in AltimateAI/altimate-code#1736.
Changelog
How did you verify your code works?
claude plugin test plugins/altimate-code: 207 pass, 0 fail across 6 files. This includes the lineage graph and layout suites, the new tool-chain and dbt-command suites, and a whole-plugin test that a Bash call passes through unchanged while every feature is a stub.Cost side effects
None. The features are stubs and make no model calls, warehouse queries or cloud requests.
Demo video
Demo video (hosted)
F.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code