Repository navigation
Conversation
Nine tool stubs exposed through `altimate tool run` (dbt_run_results, dbt_defer_state, dbt_map_relations, docs_share_comments, dbt_cost_estimate, dbt_health, dbt_sql_graph, dbt_docs_coverage, dbt_cte_profile), an exported `AltimateApi.apiRequest` that calls the backend with the stored credentials, and `dbtAdapterFor`, the one gate every adapter-backed tool goes through: it refuses read-only calls, other projects, and an adapter that did not start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hreads on shared dbt docs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… list answer is an error, comment text is quoted as data Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
|
Review-loop results for the P-14 commit (two independent reviewers, Fixed
Not changed
Not verified (unchanged): that a key stored by altimate-code is accepted by the docs-share endpoints. |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
# Conflicts: # packages/opencode/src/altimate/tools/docs-share-comments.ts
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
1 similar comment
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
…error, never 'no open threads' Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
2 similar comments
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
|
Review round 1 (independent
|
…t placeholder test Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
1 similar comment
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
|
review-loop: APPROVED at 5da9186 |
There was a problem hiding this comment.
All reported issues were addressed across 15 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (7 files)
Verified, no issue found: Fix these issues in Kilo Cloud Previous Review Summary (commit 5da9186)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5da9186)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (15 files)
Verified, no issue found: the read-only gate ( Reviewed by deepseek-v4.1-flash-1017 · Input: 61.1K · Output: 11.5K · Cached: 501K Review guidance: REVIEW.md from base branch |
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
…own statuses, strip control characters from comment text, say a failed reply may have posted, honour cancellation before the read-only gate Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
1 similar comment
|
👋 This PR was automatically closed by our quality checks. Common reasons:
If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you. |
| for (const project of projects) params.append("projects", project) | ||
| const shares = await AltimateApi.apiRequest("GET", `/dbt/dbt_docs_share/all?${params.toString()}`) | ||
| // A paginated answer wraps the shares in `items`; a bare array is accepted too. | ||
| const list = shares && !Array.isArray(shares) && Array.isArray(shares.items) ? shares.items : shares |
There was a problem hiding this comment.
[SUGGESTION]: A paginated answer is read one page deep, and total is discarded
Unwrapping items fixes the wrapper case, but nothing here handles more than the first page: total (returned alongside items in the fixture this PR adds) is stripped by SharesAnswer, so if the backend caps the page (e.g. 20 of 57 shares) list reports those threads as if the set were complete and can still answer "No open comment threads" while open threads exist on later pages. list is also the only way to discover the share_id/group_id that reply/resolve need, so hidden shares are unreachable. Either fetch the full set (largest page size, or loop until items.length >= total) or keep total in the schema and say the listing is partial when it exceeds items.length.
Issue for this PR
None.
Type of change
What does this PR do?
Replaces the
docs_share_commentsstub with a working tool (P-14, team comments).api/docs-share.ts(new):listSharedDocs(GET /dbt/dbt_docs_share/all?projects=…),listTenantUsers(GET /users/chat),replyToThread,resolveThread, all throughAltimateApi.apiRequest(api/client.ts:355).tools/docs-share-comments.ts:docs_share_comments { action: list|reply|resolve, project?, share_id?, group_id?, text? }.listreturns the open (Pending) threads with each message's author named fromusers/chat; the project defaults to thename:of the dbt project holding the working directory.replyandresolverefuse on a read-only call (ctx.extra?.forceReadOnly === true) and in plan mode, and validateshare_id,group_idand non-emptytext.test/altimate/docs-share-comments.test.ts(23 tests; the backend is replaced atAltimateApi.apiRequest, nothing is sent).This branch currently includes the shared foundation commits (
feat/pu-mods-foundation), which are not onmainyet; the P-14 change is the last commit. Merge the foundation first, then retarget/rebase.Changelog line:
docs_share_comments: list, reply to and resolve comment threads on shared dbt docs.Not verified: that a key stored by altimate-code (
~/.altimate/altimate.json) is accepted by the docs-share endpoints.How did you verify your code works?
bun test test/altimate/docs-share-comments.test.tsinpackages/opencode: 23 pass, 0 fail.bun typecheckinpackages/opencode: clean.Drove
altimate tool run docs_share_commentsagainst a local fake backend:list(cwd project and explicit), read-only refusal ofreply/resolve, and--allow-writeposting to the right endpoints with the stored key.Peer review (claude + codex as independent reviewers): one MAJOR fixed (malformed share/thread/status shown as "no open threads"), gated by a fresh reviewer.
Follow-up for the foundation, not changed here:
AltimateApi.getCredentialsparses~/.altimate/altimate.jsonwithJSON.parse, and its error text can carry a snippet of that file;apiRequestforwards it. Worth replacing with a fixed message in the shared client.Cost side effects
None. The tool makes one to two HTTP calls to the Altimate backend per
list, one perreply/resolve; no model calls or warehouse queries.Screenshots / recordings
Checklist
Demo video (hosted)
P-14.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code
Summary by cubic
Implements the
docs_share_commentstool so altimate-code can list, reply to, and resolve comment threads on shared dbt docs, and lays the foundation for the other dbt Power User tools.listreturns open (Pending) threads with author names;replyandresolvetakeshare_idandgroup_id, and refuse on read-only or plan-mode calls.name:in thedbt_project.ymlholding the working directory.AltimateApi.apiRequest, which calls the backend with the stored credentials, anddbtAdapterFor, the gate that refuses read-only calls, other projects, and an adapter that didn't start.dbt_run_results,dbt_defer_state,dbt_map_relations,dbt_cost_estimate,dbt_health,dbt_sql_graph,dbt_docs_coverage,dbt_cte_profile) that return a "not implemented" failure.apiRequest; no requests are sent in tests.Rollout
feat/pu-mods-foundationcommits, which aren't onmainyet; merge that foundation first, then rebase/retarget this PR.Written for commit 6a139dd. Summary will update on new commits.