Repository navigation
Conversation
Each feature gets its own file under hooks/features/, called by name from features/index.ts in a fixed order: its own hooks, the session and turn events, its band line and its tool-call phases. One tool.call hook (tool-chain.ts) runs Bash and file handling in fixed phases: bashRewrite, bashGate, the call, bashAfter, editAfter, readOrEditAfter. The status line is built from parts (status-line.ts). runTool moves to altimate-cli.ts with a `write` option that goes through the CLI with --allow-write. dbt-command.ts finds the dbt invocations in a shell command line. New userConfig fields: maxScanBytes, healthBlocksPush, healthConfigPath, commentsPollSeconds, commentsInContext. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…omments pane Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Subshells after keywords, case patterns, process substitution, arrays, arithmetic and function definitions parse again; quotes in a heredoc inside a substitution are text; a function or case pattern named dbt is not an invocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… double post, no stale refresh, comment text quoted as data Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review-loop results for the P-14 commit (two independent reviewers, Fixed
Not changed
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
# Conflicts: # plugins/altimate-code/hooks/features/comments.tsx
…flight work on a new session, a resolved thread never comes back from an older list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review round 1 (independent
|
|
review-loop: APPROVED at af487e2 |
Code Review SummaryStatus: 2 Issues Found | Recommendation: Merge with minor suggestions Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Incremental review of Reviewed statically (read-only run: no test suite executed). Existing discussion on the PR was read and its findings are not repeated here. Fix these issues in Kilo Cloud Previous Review Summary (commit af487e2)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit af487e2)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (22 files)
Reviewed statically (read-only run: no test suite executed). Existing discussion on the PR was read and its findings are not repeated here. Reviewed by deepseek-v4.1-flash-1017 · Input: 46.3K · Output: 12K · Cached: 448.8K |
…threads in one pass over the text Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
| threads: resolved ? current.threads.filter(one => one.shareId !== thread.shareId || one.groupId !== thread.groupId) : current.threads, | ||
| })) | ||
| // The buttons are back: the next press must not be dropped while the refresh runs. | ||
| release() |
There was a problem hiding this comment.
SUGGESTION: the new release-before-refresh window has no regression test
Nothing in hooks/comments.test.tsx presses a thread button after a post succeeds while its refresh list is still in flight: the two holdListCall tests (lines 242 and 308) hold a list that starts before the post. This release() is the whole fix for the previous finding, and it is easy to undo by accident (moving it back below await load($), or dropping the released guard) without any test failing. A test that holds the list call that follows a successful post and presses the button before it resolves would pin the behavior.
What
Team comments (P-14). Open comment threads from the team's shared dbt docs reach Claude when it reads or edits that model, and the person can reply or resolve from a pane.
hooks/features/comments.tsx: loads the open threads atsession.startand everycommentsPollSeconds(default 900) with$.clock.every; skipped in non-interactive runs.readOrEditAfter: when the file belongs to a model with open threads, adds one context block naming each thread's line and text. A thread is placed by searching the file forhighlightfirst, then its storedrange. Capped at 8 threads / 600 chars per message.commentsInContext: falsekeeps comments out of Claude's context./commentspane: threads by model, anInputwith Reply, and Resolve. Posting goes throughrunTool(..., { write: true })(CLI with--allow-write); Claude never posts.💬 N open team commentswith an Open button when threads exist.docs_share_commentsshows one line (newer altimate-code than 0.12.10), no retry loop.types/index.d.ts:CommentsState,CommentsThread.hooks/comments.test.tsx(thread placement, context block, read adds context, poll, resolve with write permission, old CLI, refused post).This branch includes the shared foundation commit; merge the foundation first. Merge the altimate-code PR (AltimateAI/altimate-code#1730) before this one, since the plugin calls the installed CLI.
Changelog line: Team comments: open threads from shared dbt docs reach Claude's context; reply or resolve from
/comments.Checks
claude plugin test ./plugins/altimate-code: 230 pass, 0 fail.bash tests/*.sh: all pass.claude plugin validate --strict .: passes.claude plugin validate --strict ./plugins/altimate-code: no warning from this change; it still fails on warnings that exist without it (missing plugin icon, TS warnings inhooks/lineage.test.tsx).Not verified: that a key stored by altimate-code (
~/.altimate/altimate.json) is accepted by the docs-share endpoints.commentsInContextis off, a/clearwith a post or list in flight blocking later ones, and a resolved thread coming back from a list asked for before the post (each with a regression test that fails without the fix); each fix was gated by a fresh reviewer.metadata.threadsfromtool run --json, which the CLI prints (src/cli/cmd/tool.ts:236) and the demo exercises.Demo video (hosted)
P-14.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).
🤖 Generated with Claude Code