Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/tenantq/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ def build_filter(
models.FieldCondition(key=CATEGORY_FIELD, match=models.MatchValue(value=category))
)
if created_after is not None or created_before is not None:
if (
created_after is not None
and created_before is not None
and created_after > created_before
):
raise ValueError(
f"created_after ({created_after}) must be ≤ created_before ({created_before})"
)
must.append(
models.FieldCondition(
key=CREATED_AT_FIELD,
Expand Down
12 changes: 12 additions & 0 deletions tests/test_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,15 @@ def test_build_filter_accepts_tenant_with_internal_spaces():
from tenantq.search import build_filter
f = build_filter("acme corp")
assert f.must


def test_build_filter_rejects_impossible_range():
from tenantq.search import build_filter
with pytest.raises(ValueError, match="must be"):
build_filter("acme", created_after=200, created_before=100)


def test_build_filter_allows_wide_open_range():
from tenantq.search import build_filter
f = build_filter("acme", created_after=100, created_before=200)
assert f.must
Loading