fix: reject impossible created range in build_filter() - #17
Merged
royalpinto007 merged 1 commit intoSep 16, 2026
Merged
Conversation
created_after > created_before silently built an impossible Range(gte, lte) that returned empty with no error, hiding caller bugs. Raise ValueError when the range is inverted. Closes AgentPostmortem#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
build_filter()withcreated_after > created_beforesilently built an impossibleRange(gte, lte)that always returned empty with no error, hiding caller bugs.Change
Raise
ValueErrorwhen the created range is inverted, so the caller learns immediately instead of chasing empty results.Tests
Added a failing test first:
build_filter("acme", created_after=200, created_before=100)raisesValueError, whilecreated_after=100, created_before=200still builds the filter. Suite: 24 passed.ruff checkclean.Related
Closes #12