Skip to content

Update ANNIEEventTreeMaker to save the LAPPD trigger timing #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anuj-guptta wants to merge 2 commits into
base: Application
Choose a base branch
from
Open

Update ANNIEEventTreeMaker to save the LAPPD trigger timing #389

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0420b9
Update ANNIEEventTreeMaker to save the LAPPD trigger timing
anuj-guptta Jul 3, 2026
b43f497
Update ANNIEEventTreeMaker to remove unnecessary lines of code
anuj-guptta Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions UserTools/ANNIEEventTreeMaker/ANNIEEventTreeMaker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,6 +1523,7 @@ void ANNIEEventTreeMaker::FillLAPPDPulse()
for (it = lappdPulses.begin(); it != lappdPulses.end(); it++)
{
int stripno = it->first;

vector<vector<LAPPDPulse>> stripPulses = it->second;

vector<LAPPDPulse> pulse0 = stripPulses.at(0);
Expand Down Expand Up @@ -1594,6 +1595,7 @@ void ANNIEEventTreeMaker::FillLAPPDHit()
for (it = lappdHits.begin(); it != lappdHits.end(); it++)
{
int stripno = it->first;

vector<LAPPDHit> stripHits = it->second;
for (int i = 0; i < stripHits.size(); i++)
{
Expand Down Expand Up @@ -2675,8 +2677,7 @@ void ANNIEEventTreeMaker::FillLAPPDWaveform()
// get the waveforms from channel number
unsigned long channel = it->first;
channel = channel % 1000 + 1000;
if ((channel % 1000) % 30 == 5)

@S81D S81D Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can just be these lines removed, no commented lines needed.

@anuj-guptta anuj-guptta Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, removed unnecessary lines of code in the new commit. We want to always save trigger signal.

continue;

Waveform<double> waveforms = it->second.at(0);
vector<double> wav = *waveforms.GetSamples();
vector<double> wave = wav;
Expand Down
Loading