Skip to content

Update ANNIEEventTreeMaker to save the LAPPD trigger timing - #389

Open
anuj-guptta wants to merge 2 commits into
ANNIEsoft:Applicationfrom
anuj-guptta:Trigger
Open

anuj-guptta wants to merge 2 commits into
ANNIEsoft:Applicationfrom
anuj-guptta:Trigger

Conversation

@anuj-guptta

Copy link
Copy Markdown
Contributor

Describe your changes

  • LAPPD trigger signal is stored in channel 5 one each ACDC, but was previously suppressed and not saved.
  • Updated the code to save the trigger signal along with the waveforms from the other channels.

Checklist before submitting your PR

  • This PR implements a single change (one new/modified Tool, or a set of changes to implement one new/modified feature)
  • This PR alters the minimum number of files to affect this change
  • If this PR includes a new Tool, a README and minimal demonstration ToolChain is provided
  • If a new Tool/ToolChain requires model or configuration files, their paths are not hard-coded, and means of generating those files is described in the readme, with examples provided on /pnfs/annie/persistent
  • For every new usage, there is a reason the data must be on the heap
  • For every new there is a delete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)

Additional Material

Attach any validation or demonstration files here. You may also link to relavant docdb articles.

// get the waveforms from channel number
unsigned long channel = it->first;
channel = channel % 1000 + 1000;
if ((channel % 1000) % 30 == 5)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can just be these lines removed, no commented lines needed.

@anuj-guptta anuj-guptta Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, removed unnecessary lines of code in the new commit. We want to always save trigger signal.

@S81D

S81D commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Hi Anuj - given git keeps a log of all changes, can you remove the commented lines?

@S81D S81D self-assigned this Sep 30, 2026
@anuj-guptta

anuj-guptta commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi Anuj - given git keeps a log of all changes, can you remove the commented lines?

Already done in the next commit.

@S81D

S81D commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Thank you! Ready to merge

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants