Skip to content

Fixed linter errors in workflow files output stages #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joniohtonen merged 1 commit into from
Aug 31, 2026
Merged

Fixed linter errors in workflow files output stages #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
self-hosted-runner:
labels:
- build-only
2 changes: 1 addition & 1 deletion .github/actions/create-miopen-db-branch/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ runs:
BRANCH_NAME: ${{ inputs.branch_name }}
run: |
echo "Pushing branch: ${BRANCH_NAME}"
git push origin "${BRANCH_NAME}"
git push origin "${BRANCH_NAME}"
10 changes: 6 additions & 4 deletions .github/workflows/build-and-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ jobs:

- name: Generate image tag
id: generate_tag
run: |
run: |
IMAGE_TAG=$(git rev-parse --short HEAD)
echo "tag=${IMAGE_TAG}" >> $GITHUB_OUTPUT
echo "core_image_with_tag=${{ env.CORE_IMAGE }}:${IMAGE_TAG}" >> $GITHUB_OUTPUT
echo "staging_image_with_tag=${{ env.STAGING_IMAGE }}:${IMAGE_TAG}" >> $GITHUB_OUTPUT
{
echo "tag=${IMAGE_TAG}"
echo "core_image_with_tag=${{ env.CORE_IMAGE }}:${IMAGE_TAG}"
echo "staging_image_with_tag=${{ env.STAGING_IMAGE }}:${IMAGE_TAG}"
} >> $GITHUB_OUTPUT

- name: Check architectures
id: check-archs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-core-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,4 @@ jobs:
runner: ${{ inputs.runner || vars.BUILD_RUNNER || 'build-only' }}
secrets:
DOCKERHUB_ORGANIZATION: ${{ secrets.DOCKERHUB_ORGANIZATION }}
DOCKERHUB_OAT: ${{ secrets.DOCKERHUB_OAT }}
DOCKERHUB_OAT: ${{ secrets.DOCKERHUB_OAT }}
4 changes: 3 additions & 1 deletion .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
} >> "$GITHUB_OUTPUT"

sh_files=$(echo "$all_changed" | grep '\.sh$' || true)
wf_files=$(echo "$all_changed" | grep -E '^\.github/(workflows|actions)/.*\.ya?ml$' || true)
wf_files=$(echo "$all_changed" | grep -E '^\.github/workflows/.*\.ya?ml$' || true)

{
echo "shell=$( [ -n "$sh_files" ] && echo true || echo false )"
Expand Down Expand Up @@ -140,4 +140,6 @@ jobs:
- name: Install actionlint
run: bash <(curl -s https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
- name: actionlint
env:
SHELLCHECK_OPTS: --exclude=SC2086
run: echo '${{ needs.changed-files.outputs.workflow_files }}' | xargs ./actionlint
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ repos:
hooks:
- id: shellcheck

- repo: https://github.com/rhysd/actionlint
rev: v1.7.12
hooks:
- id: actionlint
args: ['-shellcheck=']

- repo: local
hooks:
- id: check-spdx-headers
Expand Down
Loading