Skip to content

Fixed linter errors in workflow files output stages - #39

Merged
joniohtonen merged 1 commit into
mainfrom
bug/37-fix-linter-warnings-in-workflows
Aug 31, 2026
Merged

Fixed linter errors in workflow files output stages#39
joniohtonen merged 1 commit into
mainfrom
bug/37-fix-linter-warnings-in-workflows

Conversation

@joniohtonen

@joniohtonen joniohtonen commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fixed slew of linter erros in workflow files found by dependabot.

Closes #37

Background

Dependabot found a slew of linter warnings and false positive errors in workflow files. These stemmed from self-hosted runners' labels as well as missing quotes in workflow jobs' output stages. Encapsulation errors were not detected by vanilla shellcheck, as it handles only .sh files and can't dive into the scripting inside the workflows, meanwhile actionlint can actually run shellcheck against scripting inside the workflows and actions so it is a good idea to include it in the pre-commit as well.

Goals

Fix linter errors/warnings. Include actionlint in pre-commit hook to prevent similar issues in the future.

Tasks

  • Fix some $GITHUB_OUTPUT derived linter notices
  • Add yaml configuration for actionlint to disregard certain static runner labels like build-only.
  • Add actionlint as one of the linters in pre-commit, with shellcheck disabled to due to missing option to disregard certain directives causing a lot of false positives.
  • Disable one shellcheck directive when running actionlint in pr-check workflow

Tests

Workflow changes are cosmetic, testing not necessary.

@joniohtonen joniohtonen self-assigned this Aug 31, 2026
@joniohtonen joniohtonen added the bug Something isn't working label Aug 31, 2026
@joniohtonen joniohtonen linked an issue Aug 31, 2026 that may be closed by this pull request
@joniohtonen
joniohtonen force-pushed the bug/37-fix-linter-warnings-in-workflows branch 3 times, most recently from a93cd21 to 12f81b4 Compare August 31, 2026 13:04
…ionlint to dismiss false positives caused by self-hosted runners' labels and a flag to bypass one directive in workflows. In pre-commit hook, disabled shellcheck from actionlint, as it does not support that flag.
@joniohtonen
joniohtonen force-pushed the bug/37-fix-linter-warnings-in-workflows branch from 12f81b4 to 696f471 Compare August 31, 2026 13:07
@joniohtonen
joniohtonen marked this pull request as ready for review August 31, 2026 13:12
@joniohtonen
joniohtonen requested review from a team as code owners August 31, 2026 13:12
@joniohtonen
joniohtonen merged commit 76c37e1 into main Aug 31, 2026
6 checks passed
@joniohtonen
joniohtonen deleted the bug/37-fix-linter-warnings-in-workflows branch August 31, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix linter warnings in workflows

2 participants