Fixed linter errors in workflow files output stages - #39
Merged
Conversation
joniohtonen
force-pushed
the
bug/37-fix-linter-warnings-in-workflows
branch
3 times, most recently
from
August 31, 2026 13:04
a93cd21 to
12f81b4
Compare
…ionlint to dismiss false positives caused by self-hosted runners' labels and a flag to bypass one directive in workflows. In pre-commit hook, disabled shellcheck from actionlint, as it does not support that flag.
joniohtonen
force-pushed
the
bug/37-fix-linter-warnings-in-workflows
branch
from
August 31, 2026 13:07
12f81b4 to
696f471
Compare
joniohtonen
marked this pull request as ready for review
August 31, 2026 13:12
lauri9
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed slew of linter erros in workflow files found by dependabot.
Closes #37
Background
Dependabot found a slew of linter warnings and false positive errors in workflow files. These stemmed from self-hosted runners' labels as well as missing quotes in workflow jobs' output stages. Encapsulation errors were not detected by vanilla shellcheck, as it handles only .sh files and can't dive into the scripting inside the workflows, meanwhile actionlint can actually run shellcheck against scripting inside the workflows and actions so it is a good idea to include it in the pre-commit as well.
Goals
Fix linter errors/warnings. Include actionlint in pre-commit hook to prevent similar issues in the future.
Tasks
build-only.Tests
Workflow changes are cosmetic, testing not necessary.