Skip to content

Resolve WSL launch path dynamically #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADITYA-tp01 merged 1 commit into from
Aug 29, 2026
Merged

Resolve WSL launch path dynamically #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion start.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ if ($tfInstalled -match "yes") {

# Step 7: Start TrueForge
Write-Host "[7/7] Starting TrueForge in WSL..." -ForegroundColor Yellow
Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"/mnt/c/Users/adity/Documents/Mission Control/scripts/wsl`" && bash start-trueforge.sh'"
$wslPath = (wsl -e wslpath -a -u "$PSScriptRoot/scripts/wsl").Trim()
Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"$wslPath`" && bash start-trueforge.sh'"

@codeant-ai codeant-ai Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: The setup and installation steps target the Ubuntu distribution, but this launcher invokes the default WSL distribution. If the default distribution is not Ubuntu, start-trueforge.sh runs where the Node.js installation and globally installed TrueForge package are absent, causing npx to fail. Invoke both wslpath and the launcher against Ubuntu, or use the same configured distribution consistently. [api mismatch]

Severity Level: Major ⚠️ 
- ❌ TrueForge startup fails with a non-Ubuntu WSL default.
- ⚠️ Dashboard cannot connect to the TrueForge UI.
- ⚠️ Installation and launch use inconsistent distributions.

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** start.ps1
**Line:** 83:83
**Comment:**
	*Api Mismatch: The setup and installation steps target the Ubuntu distribution, but this launcher invokes the default WSL distribution. If the default distribution is not Ubuntu, `start-trueforge.sh` runs where the Node.js installation and globally installed TrueForge package are absent, causing `npx` to fail. Invoke both `wslpath` and the launcher against Ubuntu, or use the same configured distribution consistently.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Comment on lines +82 to +83

@qodo-code-review qodo-code-review Bot Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Launch uses wrong distro 🐞 Bug ≡ Correctness

Steps 5–6 install Node and TrueForge in the explicitly selected Ubuntu distribution, but the new
conversion and launch commands use whichever distribution is currently the WSL default. When another
distro is default, TrueForge starts in an environment where the required installation was never
performed and can fail at npx.
Agent Prompt 
## Issue description
The startup path conversion and TrueForge launch use WSL's default distribution even though setup installs the required runtime and package in `Ubuntu`.

## Issue Context
Ensure path resolution and execution target the same distribution configured in steps 5–6, ideally through one shared distro variable.

## Fix Focus Areas
- start.ps1[61-83]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@qodo-code-review qodo-code-review Bot Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

2. Checkout path breaks command 🐞 Bug ☼ Reliability

The converted path is interpolated as Bash source inside a PowerShell single-quoted -Command
argument without escaping it. A valid checkout path containing an apostrophe (for example
C:\Users\O'Brien\repo) terminates the PowerShell string and prevents launch, while Bash
substitutions such as $() in a directory name are evaluated inside the generated double-quoted
cd operand.
Agent Prompt 
## Issue description
The dynamically resolved checkout path is embedded directly into nested PowerShell and Bash command text, so valid shell-significant path characters can break or alter execution.

## Issue Context
Pass the path as data rather than interpolating it into Bash source, or apply correct escaping for both parsing layers. Preserve support for spaces, apostrophes, dollar signs, and backticks.

## Fix Focus Areas
- start.ps1[82-83]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Write-Host " TrueForge starting on http://localhost:8790" -ForegroundColor Green

# Done
Expand Down