Resolve WSL launch path dynamically - #18
Merged
Merged
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:XS
PR Summary by QodoResolve the TrueForge WSL launch path dynamically
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
Failed to generate code suggestions for PR |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| Write-Host "[7/7] Starting TrueForge in WSL..." -ForegroundColor Yellow | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"/mnt/c/Users/adity/Documents/Mission Control/scripts/wsl`" && bash start-trueforge.sh'" | ||
| $wslPath = (wsl -e wslpath -a -u "$PSScriptRoot/scripts/wsl").Trim() | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"$wslPath`" && bash start-trueforge.sh'" |
There was a problem hiding this comment.
Suggestion: The setup and installation steps target the Ubuntu distribution, but this launcher invokes the default WSL distribution. If the default distribution is not Ubuntu, start-trueforge.sh runs where the Node.js installation and globally installed TrueForge package are absent, causing npx to fail. Invoke both wslpath and the launcher against Ubuntu, or use the same configured distribution consistently. [api mismatch]
Severity Level: Major ⚠️
- ❌ TrueForge startup fails with a non-Ubuntu WSL default.
- ⚠️ Dashboard cannot connect to the TrueForge UI.
- ⚠️ Installation and launch use inconsistent distributions.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** start.ps1
**Line:** 83:83
**Comment:**
*Api Mismatch: The setup and installation steps target the Ubuntu distribution, but this launcher invokes the default WSL distribution. If the default distribution is not Ubuntu, `start-trueforge.sh` runs where the Node.js installation and globally installed TrueForge package are absent, causing `npx` to fail. Invoke both `wslpath` and the launcher against Ubuntu, or use the same configured distribution consistently.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Code Review by Qodo
1. Launch uses wrong distro
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+82
to
+83
| $wslPath = (wsl -e wslpath -a -u "$PSScriptRoot/scripts/wsl").Trim() | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"$wslPath`" && bash start-trueforge.sh'" |
There was a problem hiding this comment.
1. Launch uses wrong distro 🐞 Bug ≡ Correctness
Steps 5–6 install Node and TrueForge in the explicitly selected Ubuntu distribution, but the new conversion and launch commands use whichever distribution is currently the WSL default. When another distro is default, TrueForge starts in an environment where the required installation was never performed and can fail at npx.
Agent Prompt
## Issue description
The startup path conversion and TrueForge launch use WSL's default distribution even though setup installs the required runtime and package in `Ubuntu`.
## Issue Context
Ensure path resolution and execution target the same distribution configured in steps 5–6, ideally through one shared distro variable.
## Fix Focus Areas
- start.ps1[61-83]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| Write-Host "[7/7] Starting TrueForge in WSL..." -ForegroundColor Yellow | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"/mnt/c/Users/adity/Documents/Mission Control/scripts/wsl`" && bash start-trueforge.sh'" | ||
| $wslPath = (wsl -e wslpath -a -u "$PSScriptRoot/scripts/wsl").Trim() | ||
| Start-Process powershell -ArgumentList "-NoExit", "-Command", "wsl -- bash -c 'cd `"$wslPath`" && bash start-trueforge.sh'" |
There was a problem hiding this comment.
2. Checkout path breaks command 🐞 Bug ☼ Reliability
The converted path is interpolated as Bash source inside a PowerShell single-quoted -Command argument without escaping it. A valid checkout path containing an apostrophe (for example C:\Users\O'Brien\repo) terminates the PowerShell string and prevents launch, while Bash substitutions such as $() in a directory name are evaluated inside the generated double-quoted cd operand.
Agent Prompt
## Issue description
The dynamically resolved checkout path is embedded directly into nested PowerShell and Bash command text, so valid shell-significant path characters can break or alter execution.
## Issue Context
Pass the path as data rather than interpolating it into Bash source, or apply correct escaping for both parsing layers. Preserve support for spaces, apostrophes, dollar signs, and backticks.
## Fix Focus Areas
- start.ps1[82-83]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Address Qodo Review feedback by dynamically resolving the TrueForge launch script path via wslpath instead of relying on a hardcoded developer-specific absolute path.
CodeAnt-AI Description
Launch TrueForge from the correct project location on any Windows setup
What Changed
Impact
✅ Reliable TrueForge startup across Windows user folders✅ No project path changes required after checkout💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.