fix(ci): provision node-gate deps in merge-group integration verify - #1312
Conversation
ci.yml (which npm-ci's the worker + moneta) does not run on merge_group, but pr-gate's integration step runs node gates directly (worker-check = `npm run check`) without --skip-ci-covered, so it can block the merge on a real composition failure. Nothing installed those gates' node_modules in the merge-group runner, so the first web/worker-touching PR to traverse the queue (#1265, which also adds the yaml/ajv worker deps) failed worker-check with ERR_MODULE_NOT_FOUND — even though its exact-head CI was green (that path defers worker-check to ci.yml:worker, which does install deps). Add a merge_group-only Node setup + a path-gated `npm ci` (web/worker, moneta) before the integration verify. Ordinary Python/docs merge groups implicate no node gate and pay nothing. Reproduced locally: rm -rf node_modules && npm run check -> ERR_MODULE_NOT_FOUND (fail 3); npm ci && npm run check -> 33/33 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Multi-agent review roll call (CodeRabbit and Claude review automatically. Reviewers: post substantive findings only. Authors/agents: address every thread, push fixes to this branch, reply and resolve, then re-request review.) |
|
To use Codex here, create a Codex account and connect to github. |
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 239b45ec2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| exit 2 | ||
| fi | ||
| changed="$(git diff --name-only "$MERGE_GROUP_BASE_SHA"...HEAD || true)" | ||
| if printf '%s\n' "$changed" | grep -q '^web/worker/'; then |
There was a problem hiding this comment.
For merge groups that touch web/app/** or spec/**, scripts/verify.py --changed --integration selects the web-build gate, whose command runs cd web/app && npm run generate:data && npm run build. On a fresh merge-queue runner those scripts need web/app/node_modules (e.g. next), but this provisioning step only installs deps for web/worker and moneta, so dashboard/spec PRs can still be evicted from the queue with missing Node dependencies.
Useful? React with 👍 / 👎.
1 participant
Problem
#1265(peer-conductor mesh) kept being evicted from the merge queue (QUEUE-REMOVED) despite CLEAN exact-head CI. Root cause, proven this session:merge_groupPR Gate run for feat: add symmetric peer-conductor mesh substrate #1265 fails; every board-projection PR's succeeds.worker-check(cd web/worker && npm run check) withERR_MODULE_NOT_FOUND: 'yaml'/'ajv'.ci.yml— whichnpm ci's the worker + moneta — does not trigger onmerge_group(only push / pull_request / workflow_dispatch).--skip-ci-covered), by design, so it can block the merge on a real composition failure — but nothing provisions the worker'snode_modulesin that runner.web/worker-touching PR to traverse the queue (feat: add symmetric peer-conductor mesh substrate #1265, which also adds theyaml/ajvdeps) fails, even though its exact-head CI is green (that path defersworker-checktoci.yml:worker, which installs deps).Latent class-bug, not a #1265 code problem.
Fix
Add a
merge_group-only Node setup + a path-gatednpm ci(web/worker, moneta) before the integration verify. Ordinary Python/docs merge groups implicate no node gate and pay nothing.Verification
rm -rf web/worker/node_modules && npm run check→ERR_MODULE_NOT_FOUND(# fail 3);npm ci && npm run check→ 33/33 pass.scripts/verify.py --changed(this diff): Scoped verification passed — includingmerge-queue-contract-test,workflow-yaml,check-gates,direct-main-writer-contract..github/workflows/**→ its ownmerge_groupimplicates noworker-check→ no chicken-and-egg.Unblocks #1265 and every future
web/worker-touching PR through the merge queue.🤖 Generated with Claude Code