Skip to content

fix(ci): derive merge-group node-dep provisioning from the gate registry - #1317

Merged
4444J99 merged 1 commit into
mainfrom
fix/provision-node-deps-derive
Jul 19, 2026
Merged

fix(ci): derive merge-group node-dep provisioning from the gate registry#1317
4444J99 merged 1 commit into
mainfrom
fix/provision-node-deps-derive

Conversation

@4444J99

@4444J99 4444J99 commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Problem

Follow-up to #1312. That PR fixed worker-check failing in the merge queue (empty node_modules) but provisioned only web/worker + moneta via a hardcoded path check. #1265 also touches spec/**, which implicates the web-build gate — so its merge-group integration verify then failed with ERR_MODULE_NOT_FOUND: 'yaml' from web/app/scripts/generate-static-data.mjs: web/app's node_modules was never installed. Hardcoding a third dir would just defer the next miss.

Fix

Replace the hardcoded path checks with scripts/provision-merge-group-node-deps.py, which derives the dirs to install from the SAME registry + implication logic verify.py --integration uses (load_registry / changed_set / select): for every gate the merge-group diff implicates whose command is cd <dir> && npm ..., run npm ci in <dir>.

  • A new node gate is covered the moment it lands in gates.yaml — no dir list to keep in lockstep (the repo's derive-don't-pin pattern, like check-gates).
  • Gates that only run a root-level node script.mjs on built-ins (contract-schemas) need no install and are correctly excluded.

Verification

  • Derivation unit-checked: #1265-like diff (web/worker + spec) → ['web/app', 'web/worker']; moneta-only → ['moneta']; python/docs-only → [] (no-op).
  • scripts/verify.py --changed green — incl. merge-queue-contract-test, workflow-yaml, check-gates. ruff clean.
  • Touches only .github/workflows/** + scripts/** → its own merge_group implicates no node gate → merges clean.

Completes the merge-group node-dep fix so #1265 (and every future spec/web-app/worker/moneta PR) passes the queue.

🤖 Generated with Claude Code

#1312 provisioned only web/worker + moneta by a hardcoded path check, so #1265
(which also touches spec/**, implicating the web-build gate) then failed the
merge-group integration verify with ERR_MODULE_NOT_FOUND: 'yaml' from
web/app/scripts/generate-static-data.mjs — web/app node_modules was never
installed. Hardcoding a third dir would just defer the next miss.

Replace the hardcoded path checks with scripts/provision-merge-group-node-deps.py,
which reuses verify.py's own load_registry/changed_set/select so it installs
exactly the node projects the merge-group diff implicates: for every selected gate
whose command is `cd <dir> && npm ...`, run npm ci in <dir>. A new node gate is
covered the moment it lands in gates.yaml — no dir list to keep in lockstep. Gates
that only run a root-level `node script.mjs` on built-ins (contract-schemas) need
no install and are correctly excluded.

Verified: for a #1265-like diff (web/worker + spec) the script derives
['web/app', 'web/worker']; moneta-only → ['moneta']; python/docs-only → [] (no-op).
Scoped verify green incl. merge-queue-contract-test + check-gates; ruff clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Multi-agent review roll call
@codex review

(CodeRabbit and Claude review automatically. Reviewers: post substantive findings only. Authors/agents: address every thread, push fixes to this branch, reply and resolve, then re-request review.)

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@4444J99, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0ce4a48c-17da-4f46-87ff-b037f05b6069

📥 Commits

Reviewing files that changed from the base of the PR and between 7a5101a and 312d8b0.

📒 Files selected for processing (2)
  • .github/workflows/pr-gate.yml
  • scripts/provision-merge-group-node-deps.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/provision-node-deps-derive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@4444J99
4444J99 enabled auto-merge July 19, 2026 23:16
@4444J99
4444J99 added this pull request to the merge queue Jul 19, 2026
Merged via the queue into main with commit 1f8066c Jul 19, 2026
13 checks passed
@4444J99
4444J99 deleted the fix/provision-node-deps-derive branch August 5, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant