fix(ci): derive merge-group node-dep provisioning from the gate registry - #1317
Conversation
#1312 provisioned only web/worker + moneta by a hardcoded path check, so #1265 (which also touches spec/**, implicating the web-build gate) then failed the merge-group integration verify with ERR_MODULE_NOT_FOUND: 'yaml' from web/app/scripts/generate-static-data.mjs — web/app node_modules was never installed. Hardcoding a third dir would just defer the next miss. Replace the hardcoded path checks with scripts/provision-merge-group-node-deps.py, which reuses verify.py's own load_registry/changed_set/select so it installs exactly the node projects the merge-group diff implicates: for every selected gate whose command is `cd <dir> && npm ...`, run npm ci in <dir>. A new node gate is covered the moment it lands in gates.yaml — no dir list to keep in lockstep. Gates that only run a root-level `node script.mjs` on built-ins (contract-schemas) need no install and are correctly excluded. Verified: for a #1265-like diff (web/worker + spec) the script derives ['web/app', 'web/worker']; moneta-only → ['moneta']; python/docs-only → [] (no-op). Scoped verify green incl. merge-queue-contract-test + check-gates; ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Multi-agent review roll call (CodeRabbit and Claude review automatically. Reviewers: post substantive findings only. Authors/agents: address every thread, push fixes to this branch, reply and resolve, then re-request review.) |
|
To use Codex here, create a Codex account and connect to github. |
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Follow-up to #1312. That PR fixed
worker-checkfailing in the merge queue (emptynode_modules) but provisioned onlyweb/worker+monetavia a hardcoded path check. #1265 also touchesspec/**, which implicates theweb-buildgate — so its merge-group integration verify then failed withERR_MODULE_NOT_FOUND: 'yaml'fromweb/app/scripts/generate-static-data.mjs:web/app'snode_moduleswas never installed. Hardcoding a third dir would just defer the next miss.Fix
Replace the hardcoded path checks with
scripts/provision-merge-group-node-deps.py, which derives the dirs to install from the SAME registry + implication logicverify.py --integrationuses (load_registry/changed_set/select): for every gate the merge-group diff implicates whose command iscd <dir> && npm ..., runnpm ciin<dir>.gates.yaml— no dir list to keep in lockstep (the repo's derive-don't-pin pattern, likecheck-gates).node script.mjson built-ins (contract-schemas) need no install and are correctly excluded.Verification
#1265-like diff (web/worker+spec) →['web/app', 'web/worker'];moneta-only →['moneta']; python/docs-only →[](no-op).scripts/verify.py --changedgreen — incl.merge-queue-contract-test,workflow-yaml,check-gates.ruffclean..github/workflows/**+scripts/**→ its own merge_group implicates no node gate → merges clean.Completes the merge-group node-dep fix so #1265 (and every future spec/web-app/worker/moneta PR) passes the queue.
🤖 Generated with Claude Code