Add hyperEVM network, switch monad to registerCustom - #269
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds hyperEVM (chain id 999) to
Networksand changesmonad(chain id 143) fromregistertoregisterCustom, so both go through the Etherscan v2 multichain API with explicit explorer URLs (hyperevmscan.com,monadscan.com) and thecancunEVM version. Version bumped to 6.9.12.These are the two commits that were accidentally pushed straight to
master; they have been rebased onto the pre-push base so they can be reviewed here. #268 reverts them frommasterand should be merged first.Static Code Analysis (readability, compactness):
Both networks now use the same
registerCustomshape as the neighbouring cronos entries, so the block is more uniform than before.monadmoves out of the plainregistergroup.Dynamic Code Analysis (external APIs, interaction flows):
Both entries depend on
HYPEREVM_RPC_URL/MONAD_RPC_URLenv vars and the shared Etherscan API key. Verification for monad now points atapi.etherscan.io/v2/api?chainid=143rather than the namedmonadEtherscan preset — worth confirming that key has v2 access for both chains before relying onverify.Efficiency (gas costs, computational complexity, memory requirements):
Not applicable — hardhat network config only, no Solidity changes.
Opinion, trade-offs and other thoughts (optional):
The monad change is a behaviour change bundled with a new-network addition; it was reviewed together here because both arrived in the same commit.
Made with Cursor