Revert accidental direct push to master - #268
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits 786dbb9 (
add hyperevm) and 85a1f06 (bump version) were pushed directly tomasterby mistake, bypassing review. This reverts both, restoringmasterto the state it had after #267.The changes themselves are not being dropped — they come back through #269 (
chains/hyperevm), which contains the same two commits rebased onto the pre-push base so they can be reviewed normally.Merge this one first, then #269.
Static Code Analysis (readability, compactness):
Pure revert, no hand-written changes:
hardhat-setup/networks.tsloses the hyperEVM entry and restores the previousmonadregistration,package.jsonreturns to 6.9.11.Dynamic Code Analysis (external APIs, interaction flows):
No contract code touched. The hyperEVM RPC config is removed, so nothing can resolve that network until #269 lands.
Efficiency (gas costs, computational complexity, memory requirements):
Not applicable — no Solidity changes.
Opinion, trade-offs and other thoughts (optional):
Revert-then-reapply was chosen over force-pushing
master, so the published history stays intact for anyone who already fetched it. The cost is two extra commits in the log.