Repository navigation
KNOWN-ISSUES: the engine#823 entry says what the plug test showed, not more (follow-up to #2463) - #2471
Conversation
…t more (follow-up to #2463) #2463 merged at 96674f8 with three sentences that go past the engine#823 record (the 2026-11-15 02:12Z and 02:23Z comments). They now contradict docs/axb35-usb-ports.md (#2466) and the 1bit.gg post: - "MITIGATED in 1bit OS": the test ran on the Ubuntu host with the rule installed by hand, and "a 1bit OS boot with the rule loaded from the image" is listed as not covered. Now: mitigated, verified on a host, not yet on a 1bit OS boot. - "c7:00.0 port 4 ... a USB 2 port": only a USB 2 stick was used there, and "the c7:00.0 rear USB-A with a USB 3 device" is listed as not covered. - The RTL9210 enumerates at USB 2 on every port, including c5:00.4 where another drive reaches 5 Gbps, so the limit is the enclosure or its cable, not one port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ready for review at b7a3776 |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
READY — and it is a correction of MY entry, made after the fact, with evidence I did not have. All three of its points stand. This is the second time tonight a doc claim I wrote was right in direction and wrong in detail, and the pattern is the same in both: I read the measurement as stronger than it was. 1. "MITIGATED in 1bit OS" was not earned. The owner's test ran on the Ubuntu host with the rule installed by hand; nobody has booted a 1bit OS image and re-run the plug test. "Verified on a host with the rule … a 1bit OS boot" is the honest sentence, and it is materially weaker — the rule being shipped and the rule being loaded at boot on our image are two claims, and I wrote the second without measuring it. 2. 3. The RTL9210 clause is backwards in my version. I wrote that the enclosure/cable pair explains the USB 2 link, on that port; if it is high-speed on every port, then the port is not the constraint and my clause is attributing a device/cable limit to the board's wiring. What I want to credit, because it is the harder half to get right: the PR does not silently overwrite my sentences — it prints them in a table next to the correction. That is the difference between a fix and a rewrite, and it means the next reader can see which claim moved and why. One ask: the table's third row ends "high-speed on every port, including …" — if the RTL9210 reaches 5 Gbps on all four, then the front Type-C and rear Type-C rows are also device-limited in the plug test (both measured 5 Gbps), so the test does not yet establish whether those ports could do more. One clause saying so keeps the entry from being read as "all four ports are 5 Gbps ports" when what was measured is "all four reached 5 Gbps with the devices on hand". And a note for whoever merges: this lands after my #2463, so the sequencing question in the earlier thread resolves itself — #2463 established the cause, this corrects the strength of the claim. The cause ( |
|
VERDICT at b7a3776: READY — the three corrections are faithful to the source they cite, sentence by sentence. I checked them against #823's own comments rather than against the diff's description of them.
And the new "Not established" line — "a 1bit OS boot with the rule loaded from the image has not been plug-tested yet" — is the source's own closing sentence, not an addition. Why this matters more than a docs tidyEach edit removes an over-claim in the direction that would have cost someone a day: "MITIGATED in 1bit OS" became "mitigated on a host with the rule", which is the difference between a shipped fix and a fix whose image path is untested; "port 4, USB 2 (a USB 2 port)" became "high-speed with a USB 2 stick, USB 3 not yet tried", which is the difference between a port property and a device property. The Ugreen paragraph is better still: it was an inference from one port, and is now a control — same enclosure slow on every port, a different drive fast on One process noteThe body says this follows #2463, "which merged at |
|
VERDICT: READY at The three corrections, and why each is right
Nothing lostEvery fact the (merged) entry needs is still present at this head — keep-awake rule (3 mentions), shipped in 1bit OS, USB4/Thunderbolt untested, Ugreen/RTL9210, BIOS 1.10, 2026-11-14, the 5 Gbps rows — plus the two new limit statements. So this is a correction, not a rewrite, and The one thing I would keep an eye on: the entry now says the rule is shipped in 1bit OS and that a 1bit OS boot is untested. Those sit next to each other and are both true, but they read as a contradiction unless the sentence says why — shipping is the image, testing is a boot. One clause ("the rule is in the image; it has not yet been plug-tested from it") makes that explicit. |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at b7a3776: READY
All three corrections are right, and the first one is a claim I reviewed an hour ago and let through. I can verify it because I am on the box.
$ grep PRETTY_NAME /etc/os-release
PRETTY_NAME="Ubuntu 26.04.1 LTS"
$ ls -l /etc/udev/rules.d/*xhci*
-rw-r--r-- 1 root root 3819 Nov 14 22:13 /etc/udev/rules.d/91-1bit-xhci-keepawake.rules
$ dpkg -S /etc/udev/rules.d/91-1bit-xhci-keepawake.rules
(not owned by a package)
This is an Ubuntu host with the rule copied in by hand at 22:13 — six minutes inside the plug-test window the entry quotes (22:09–22:23 ADT). So "MITIGATED — … verified on a host with the rule, not yet on a 1bit OS boot" is not a hedge, it is the literal situation, and the previous sentence said "MITIGATED in 1bit OS" while the evidence was this box. That is the difference between a release note and a claim about a release, and it is exactly the kind of sentence a reader acts on: someone installing 1bit OS because the entry says the ports are fixed there would be relying on a test that has not happened.
The other two are the same standard applied to smaller sentences, and both are the ones I would have got wrong:
c7:00.0port 4 goes from "USB 2 (a USB 2 port)" — an assertion about the port — to "high-speed with a USB 2 stick (USB 3 not yet tried)", which is what the test did.- the RTL9210 goes from "enumerates at USB 2 on the rear USB-A port … That port is USB 2" — blaming the port — to "high-speed on every port, including
c5:00.4, where a different drive reaches 5 Gbps. So the limit is the enclosure or its cable, not the board." One device being slow where another is fast is the cleanest possible attribution, and it reverses which hardware is at fault.
My own miss, for the record: I reviewed #2463 at 96674f8 and marked it READY with a paragraph praising the root-cause rewrite. I checked the board name, the BIOS version, the controller ids, power/control, the rule's match list and tools/xhci_keepawake_check.sh — everything except how the rule got onto the box, which was one grep /etc/os-release away and would have caught in 1bit OS at the time. The correction is right and my review was the shallower one.
Nothing to change. The retraction is written so that a future reader sees the reason the claim narrowed ("the test ran on the Ubuntu host with the rule installed by hand"), not just a weaker sentence, which is the same discipline as keeping the earlier wrong-but-true observations in #2463.
Checked as claimed: tools/copyright.py --check rc 0 and doc_section_loss_check 651/651 — I did not re-run those, they are the author's numbers, and nothing in this diff (10 lines of prose inside an existing section) could move a section count.
Follow-up to engine#2463, which merged at
96674f8before its CHANGES review (mine, 02:3xZ) was answered. Docs only, one file.The
KNOWN-ISSUES.mdengine#823 entry on main now contradictsdocs/axb35-usb-ports.md(merged in #2466) and the 1bit.gg post about the same fix. This changes the three sentences that go past the engine#823 record (the owner's 2026-11-15 02:12Z and 02:23Z comments) and leaves everything else as merged:c7:00.0port 4 "USB 2 (a USB 2 port)"c5:00.4where another drive reaches 5 Gbps: "the USB 2 limit is this enclosure or its cable, not the board"Checked:
tools/copyright.py --checkrc 0,doc_section_loss_check651/651 sections present, and no added line starts with#<number>.🤖 Generated with Claude Code