Skip to content

Default download smoke review queue output #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1613358894 merged 1 commit into from
Aug 3, 2026
Merged

Default download smoke review queue output #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,9 @@ compatibility argv list. When `inspect --write` succeeds on at least one
bounded row, `recommended_review_queue_request_target`,
`recommended_review_queue_request`, and `recommended_review_queue_next_command`
point to the next local `coverage-pipeline server-validation-result
review-queue` handoff for the written inspection directory.
review-queue` handoff for the written inspection directory, using
`download_smoke_review_queue.tsv` inside that inspection directory as the
default output path.
The inspection does not run `datasets`, extract ZIPs, write raw sequence text,
access the network, contact providers, or mutate workflow outputs.

Expand Down
7 changes: 4 additions & 3 deletions tests/test_cli_download_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,18 +2028,19 @@ def test_download_smoke_inspect_write_outputs_row_quality_gate_blockers(
assert summary["recommended_review_queue_request_target"] == (
"coverage-pipeline server-validation-result review-queue"
)
review_queue_path = outdir / "download_smoke_review_queue.tsv"
assert summary["recommended_review_queue_request"] == {
"command": "coverage-pipeline",
"subcommand": "server-validation-result review-queue",
"download_smoke_inspection_dir": str(outdir),
"write": True,
"out": "<download_smoke_review_queue.tsv>",
"out": str(review_queue_path),
"json": True,
}
assert summary["recommended_review_queue_next_command"] == (
"typetreeflow coverage-pipeline server-validation-result review-queue "
f"--download-smoke-inspection-dir {outdir} --write --out "
"<download_smoke_review_queue.tsv> --json"
f"{review_queue_path} --json"
)
assert (
main(
Expand All @@ -2061,7 +2062,7 @@ def test_download_smoke_inspect_write_outputs_row_quality_gate_blockers(
str(outdir),
"--write",
"--out",
"<download_smoke_review_queue.tsv>",
str(review_queue_path),
"--json",
]

Expand Down
5 changes: 3 additions & 2 deletions typetreeflow/download_smoke_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,13 @@ def _recommended_command_from_request(


def _recommended_review_queue_request(inspection_dir: str | Path) -> dict[str, object]:
inspection_path = Path(inspection_dir)
return {
"command": "coverage-pipeline",
"subcommand": "server-validation-result review-queue",
"download_smoke_inspection_dir": str(Path(inspection_dir)),
"download_smoke_inspection_dir": str(inspection_path),
"write": True,
"out": "<download_smoke_review_queue.tsv>",
"out": str(inspection_path / "download_smoke_review_queue.tsv"),
"json": True,
}

Expand Down
Loading