Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DotNet/MarshalBlobReader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ MarshalType Read() {
var custMarshalerName = ReadUTF8String();
var cmRef = custMarshalerName.DataLength == 0 ? null : TypeNameParser.ParseReflection(module, UTF8String.ToSystemStringOrEmpty(custMarshalerName), new CAAssemblyRefFinder(module), gpContext);
var cookie = ReadUTF8String();
returnValue = new CustomMarshalType(guid, nativeTypeName, cmRef, cookie);
returnValue = new CustomMarshalType(guid, nativeTypeName, custMarshalerName, cmRef, cookie);
break;

case NativeType.IUnknown:
Expand Down
34 changes: 31 additions & 3 deletions src/DotNet/MarshalType.cs
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ public ArrayMarshalType(NativeType elementType, int paramNum, int numElems, int
public sealed class CustomMarshalType : MarshalType {
UTF8String guid;
UTF8String nativeTypeName;
UTF8String custMarshalerTypeName;
ITypeDefOrRef custMarshaler;
UTF8String cookie;

Expand All @@ -382,8 +383,18 @@ public UTF8String NativeTypeName {
set => nativeTypeName = value;
}

/// <summary>
/// Gets/sets the custom marshaller type name string
/// <remarks>This property is used when writing only when <see cref="CustomMarshaler"/> is null.</remarks>
/// </summary>
public UTF8String CustomMarshalerTypeName {
get => custMarshalerTypeName;
set => custMarshalerTypeName = value;
}

/// <summary>
/// Gets/sets the custom marshaler
/// <remarks>This property takes priority over <see cref="CustomMarshalerTypeName"/> when writing.</remarks>
/// </summary>
public ITypeDefOrRef CustomMarshaler {
get => custMarshaler;
Expand Down Expand Up @@ -427,7 +438,7 @@ public CustomMarshalType(UTF8String guid, UTF8String nativeTypeName)
/// </summary>
/// <param name="guid">GUID string</param>
/// <param name="nativeTypeName">Native type name string</param>
/// <param name="custMarshaler">Custom marshaler name string</param>
/// <param name="custMarshaler">Custom marshaler type</param>
public CustomMarshalType(UTF8String guid, UTF8String nativeTypeName, ITypeDefOrRef custMarshaler)
: this(guid, nativeTypeName, custMarshaler, null) {
}
Expand All @@ -437,18 +448,35 @@ public CustomMarshalType(UTF8String guid, UTF8String nativeTypeName, ITypeDefOrR
/// </summary>
/// <param name="guid">GUID string</param>
/// <param name="nativeTypeName">Native type name string</param>
/// <param name="custMarshaler">Custom marshaler name string</param>
/// <param name="custMarshaler">Custom marshaler type</param>
/// <param name="cookie">Cookie string</param>
public CustomMarshalType(UTF8String guid, UTF8String nativeTypeName, ITypeDefOrRef custMarshaler, UTF8String cookie)
: this(guid, nativeTypeName, null, custMarshaler, cookie) {
}

/// <summary>
/// Constructor
/// </summary>
/// <param name="guid">GUID string</param>
/// <param name="nativeTypeName">Native type name string</param>
/// <param name="custMarshalerTypeName">Custom marshaler name string</param>
/// <param name="custMarshaler">Custom marshaler type</param>
/// <param name="cookie">Cookie string</param>
public CustomMarshalType(UTF8String guid, UTF8String nativeTypeName, UTF8String custMarshalerTypeName, ITypeDefOrRef custMarshaler, UTF8String cookie)
: base(NativeType.CustomMarshaler) {
this.guid = guid;
this.nativeTypeName = nativeTypeName;
this.custMarshalerTypeName = custMarshalerTypeName;
this.custMarshaler = custMarshaler;
this.cookie = cookie;
}

/// <inheritdoc/>
public override string ToString() => $"{nativeType} ({guid}, {nativeTypeName}, {custMarshaler}, {cookie})";
public override string ToString() {
if (custMarshaler is not null)
return $"{nativeType} ({guid}, {nativeTypeName}, {custMarshaler}, {cookie})";
return $"{nativeType} ({guid}, {nativeTypeName}, {custMarshalerTypeName}, {cookie})";
}
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/DotNet/Writer/MarshalBlobWriter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ byte[] Write(MarshalType marshalType) {
Write(custMarshaler.Guid);
Write(custMarshaler.NativeTypeName);
var cm = custMarshaler.CustomMarshaler;
var cmName = cm is null ? string.Empty : FullNameFactory.AssemblyQualifiedName(cm, this);
UTF8String cmName = cm is null ? custMarshaler.CustomMarshalerTypeName : FullNameFactory.AssemblyQualifiedName(cm, this);
Write(cmName);
Write(custMarshaler.Cookie);
break;
Expand Down
Loading