Preserve the type name string in CustomMarshalType if parsing it fails - #576
Merged
Merged
Conversation
wtfsck
self-requested a review
May 31, 2026 18:45
wtfsck
approved these changes
May 31, 2026
Contributor
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the type name was not parsed, any empty string was written.
This has the side effect that code relying on
GetCustomAttribute<MarshalAsAttribute>()will throw a different exception.For example:
System.ArgumentException: The name of the type is invalid. (Parameter 'typeName@0')vs.
System.ArgumentException: The value cannot be an empty string. (Parameter 'typeName')This behavior could be used to detect rewriting with dnlib as a means of anti-tampering protection.