Skip to content

Fix Store Accounting calculator layout; bump pinned ruff to 0.17.4 - #39

Merged
zzuse merged 2 commits into
mainfrom
claude/lotto-number-recognition-training-q8yi3x
Nov 7, 2026
Merged

zzuse merged 2 commits into
mainfrom
claude/lotto-number-recognition-training-q8yi3x

Conversation

@zzuse

@zzuse zzuse commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Two small follow-ups to #38.

1. Fix the Store Accounting calculator layout (regression from #38)

The lotto pages added a .lotto-row { display: flex } rule for their button rows. The Store Accounting calculator (/store_sum, under Sheet) already uses class="lotto-row" on its <tr> rows, and its JavaScript selects them by that class. So the new rule turned every calculator row into a flex box and broke the table's column layout.

2. Bump pinned ruff from 0.15.20 to 0.17.4

Updated together in all the places that must stay in sync: the CI lint job, the .pre-commit-config.yaml hook rev, and the version notes in pyproject.toml and docs/ruff_fix_plan.md. The repo already passes 0.17.4 with zero findings. Staying on 0.15.20 let a newer local ruff and CI drift apart, which broke lint on #38 (PLR0917). The lint.select list is unchanged.

Testing

  • In a browser (Playwright), the calculator is fixed:
    • all 11 lotto rows render as table-row again
    • entering 3 × $5 in Till 1 gives a $15.00 grand total
    • the columns line up with the Cash and Cigar counters
  • The lotto pages' button rows still lay out as before (flex).
  • ruff check . with ruff 0.17.4: All checks passed.
  • pytest -q: passes (57 lotto tests, including the new one), coverage 86.37%.

🤖 Generated with Claude Code

https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv

The repo already passes ruff 0.17.4 (and 0.16.9) with zero findings, so the
bump is free now; staying on 0.15.20 let local and CI ruff drift apart, which
broke CI on PR #38 (PLR0917 is enabled in newer ruff, not in 0.15.20).

Updated together: the CI lint job, the pre-commit hook rev, and the notes in
pyproject.toml and docs/ruff_fix_plan.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T22:17:19.176525Z 7a79993 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

The lotto pages styled a .lotto-row class (display: flex) for their button
rows, but the Store Accounting calculator already uses class="lotto-row" on
its <tr> rows (and its JS selects them by it). The flex rule turned every
calculator table row into a flex box and broke the column layout.

The lotto pages now use .lotto-actions instead; the calculator is
untouched. A test guards against styling .lotto-row again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv
@zzuse zzuse changed the title Bump pinned ruff from 0.15.20 to 0.17.4 Fix Store Accounting calculator layout; bump pinned ruff to 0.17.4 Nov 7, 2026
@zzuse
zzuse merged commit f2136c5 into main Nov 7, 2026
2 checks passed
@zzuse
zzuse deleted the claude/lotto-number-recognition-training-q8yi3x branch November 7, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants