Repository navigation
Fix Store Accounting calculator layout; bump pinned ruff to 0.17.4 - #39
Merged
Merged
Conversation
The repo already passes ruff 0.17.4 (and 0.16.9) with zero findings, so the bump is free now; staying on 0.15.20 let local and CI ruff drift apart, which broke CI on PR #38 (PLR0917 is enabled in newer ruff, not in 0.15.20). Updated together: the CI lint job, the pre-commit hook rev, and the notes in pyproject.toml and docs/ruff_fix_plan.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The lotto pages styled a .lotto-row class (display: flex) for their button rows, but the Store Accounting calculator already uses class="lotto-row" on its <tr> rows (and its JS selects them by it). The flex rule turned every calculator table row into a flex box and broke the column layout. The lotto pages now use .lotto-actions instead; the calculator is untouched. A test guards against styling .lotto-row again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups to #38.
1. Fix the Store Accounting calculator layout (regression from #38)
The lotto pages added a
.lotto-row { display: flex }rule for their button rows. The Store Accounting calculator (/store_sum, under Sheet) already usesclass="lotto-row"on its<tr>rows, and its JavaScript selects them by that class. So the new rule turned every calculator row into a flex box and broke the table's column layout..lotto-actionsinstead. The calculator template and JS are untouched.styles.cssstyles.lotto-rowagain.2. Bump pinned ruff from 0.15.20 to 0.17.4
Updated together in all the places that must stay in sync: the CI
lintjob, the.pre-commit-config.yamlhook rev, and the version notes inpyproject.tomlanddocs/ruff_fix_plan.md. The repo already passes 0.17.4 with zero findings. Staying on 0.15.20 let a newer local ruff and CI drift apart, which broke lint on #38 (PLR0917). Thelint.selectlist is unchanged.Testing
table-rowagainflex).ruff check .with ruff 0.17.4: All checks passed.pytest -q: passes (57 lotto tests, including the new one), coverage 86.37%.🤖 Generated with Claude Code
https://claude.ai/code/session_012k19dCKBK4J2UdDMJd5gLv