feat: add native socket RAII wrapper - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first platform networking primitive for v1: an internal move-only RAII wrapper around native socket handles.
Added
src/platform/native_socket.hppNativeSocketHandleabstractionSOCKET/ POSIX file-descriptor invalid-state handlingNativeSocketvalid(),get(),release(),reset(), andclose()last_socket_error()platform diagnostic helpersrc/platform/native_socket.cppclosesocket()on Windowsclose()on POSIXtests/native_socket_test.cpprelease()ownership transferBuild changes
Ws2_32only on Windowssrc/privatelyArchitecture alignment
This keeps native socket types entirely behind the implementation boundary. No Winsock/POSIX types are added to the public API, and transport/DNS/HTTP semantics remain out of this layer.
Scope
This PR intentionally does not implement DNS resolution, socket creation policy, TCP connect, timeouts, send/receive loops, or
Clientbehavior. Those build on this ownership primitive in follow-up PRs.