Repository navigation
feat: harden URL parsing and query parameters - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues roadmap milestone v0.8 by closing the URL/query correctness gap in REQ-HTTP-004 and strengthening URL validation.
Query parameter API
Request::add_query_param(name, value)Request%20rather than+Redirect integration
The effective request URL now includes appended query parameters before redirect resolution. This keeps relative/query/fragment redirect behavior consistent with the actual request target while avoiding duplicate forwarding of the original query-parameter objects to redirected requests.
URL hardening
%HHsequencesTests
Adds/extends coverage for:
Documentation
Updates the public API contract with the query-parameter and URL-validation behavior.
Scope
This PR does not alter TCP transport, response framing, connection reuse, or redirect status/method policy. v0.8 remains in progress after this PR; the next substep is the HTTP correctness review.