feat: add timed TCP read and write I/O - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the byte-oriented v1 TCP transport primitive by adding bounded synchronous reads and complete writes with partial-I/O handling.
Added
src/platform/socket_mode.hpp/.cppsrc/platform/socket_io.hpp/.cppselect()/ POSIXpoll()send/recvattemptsMSG_NOSIGNALwhere availableTcpConnection::write_all(std::string_view, timeout)TcpConnection::read_some(char*, capacity, timeout)SO_NOSIGPIPEsocket setup whereMSG_NOSIGNALis unavailableFailure semantics
ConnectionClosedWriteTimeoutReadTimeoutWriteFailed/ReadFailedTests
Tests use loopback sockets only and require no public network access.
CI cleanup
benchmarks/CMakeLists.txtis still empty, so CI no longer downloads/builds Benchmark unnecessarilyScope
This PR completes the low-level synchronous TCP byte stream needed by the HTTP layer. It intentionally does not implement HTTP request serialization, response parsing, chunked decoding, redirects, or connection reuse policy yet.