Support predictable Git-style file ignore patterns - #348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace substring matching in
file_ignorewith Git-style filename patterns using the already-transitiveignorecrate. Support nested basenames, anchored paths, directory patterns, glob wildcards, ordered negation, and contextual errors for invalid patterns. Report each excluded file with the rule that matched it.For example,
Cargo.locknow excludes that filename at any depth without excludingCargo.lock.backup;vendor/*followed by!vendor/README.mdkeeps that README. Document migration from substring rules and clarify that gptcommit does not load Git's own ignore files.Validation:
just lint build testpassed, including 13 Rust tests and the CLI end-to-end suite. Focused tests exercise the summarization filtering boundary for rooted/nested paths, globs, re-inclusion, rule order, empty patterns, and invalid patterns. No new matcher implementation or configuration format is introduced.