Fix scoped configuration editing and typed config output - #347
Merged
Merged
Conversation
zurawiki
force-pushed
the
qol/config-editing
branch
from
September 24, 2026 14:51
053ed6c to
ba8eca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make configuration edits local to the selected file and key. For example,
config set --local openai.retries 3now writes an integer override without copying user settings, environment credentials, defaults, or prompts into the repository config. Deleting a key removes only that override, allowing normal precedence to resume. Preserve comments and unrelated entries with the existing toml_edit dependency.Print booleans, numbers, and arrays from
config getinstead of a blank line. Validate set keys and values, and accept TOML arrays forfile_ignore.Validation:
just lint build testpassed, including 20 Rust tests and a CLI regression for local edits under environment overrides. Tests cover comment preservation, sparse typed edits, deletion, unknown keys, and invalid values. Removes the merged-settings deletion helper and stops using the effective settings as the edit source.Rebased onto main at
1336779, preserving both README sections. Final checked head:ba8eca9cf6fb8d13a2e07256f6270b36af1f7456. Full local lint/build/CLI tests passed; CI passed all platform jobs, lint, the version check, and the aggregate gate.