Skip to content

fix: adjust header styling to prevent overlap with announcement bar#3

Merged
ditahkk merged 1 commit into
mainfrom
issues/keep-2ndDomain
May 31, 2026
Merged

fix: adjust header styling to prevent overlap with announcement bar#3
ditahkk merged 1 commit into
mainfrom
issues/keep-2ndDomain

Conversation

@ditahkk
Copy link
Copy Markdown
Contributor

@ditahkk ditahkk commented May 31, 2026

What changed

Why

Checklist

  • pnpm fmt && pnpm lint && pnpm typecheck && pnpm build all pass
  • Content is accurate and tested against the live portal/CLI/API
  • No internal infrastructure details, credentials, or IPs included
  • Screenshots replaced with :::note Screenshot pending::: if unavailable

Summary by CodeRabbit

  • Bug Fixes

    • Fixed header positioning to properly account for announcement bar visibility across breakpoints.
  • Chores

    • Updated deployment and configuration hostnames for dev and staging environments to reflect new domain naming convention.

…files

fix: adjust header styling to prevent overlap with announcement bar
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 473c5905-59a5-47da-b10f-3a149fd6a28b

📥 Commits

Reviewing files that changed from the base of the PR and between 0e91d26 and ff479cf.

📒 Files selected for processing (5)
  • .github/workflows/10-deploy-dev.yml
  • .github/workflows/20-deploy-stg.yml
  • deploy/caddy/dev.Caddyfile
  • deploy/caddy/stg.Caddyfile
  • src/styles/custom.css

📝 Walkthrough

Walkthrough

This PR updates deployment domain naming conventions across dev and staging environments in GitHub Actions workflows and Caddy reverse-proxy configuration, and adjusts CSS header styling to accommodate a promo announcement bar without overlapping sidebar content.

Changes

Infrastructure and Styling Updates

Layer / File(s) Summary
Dev and staging hostname updates across workflows and Caddy config
.github/workflows/10-deploy-dev.yml, .github/workflows/20-deploy-stg.yml, deploy/caddy/dev.Caddyfile, deploy/caddy/stg.Caddyfile
Domain hostnames are renamed from docs-{env}.apps.zcp.zsoftly.ca to {env}-docs.apps.zcp.zsoftly.ca consistently across smoke-test workflow steps and Caddy configuration comments for both dev and staging environments.
Header height adjustment for announcement bar
src/styles/custom.css
.header rule now sets an explicit height calculation (calc(var(--sl-nav-height) - var(--sl-announcement-height))) within the @media (min-width: 50rem) breakpoint, ensuring the header shifts down by announcement height without growing and overlapping sidebar items.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • zsoftly/zcp-docs#1: Establishes the initial deploy smoke-test flow and infrastructure configuration that this PR updates with corrected hostname naming conventions.

Suggested reviewers

  • ditahm6

Poem

🐰 A rabbit hops through config land,
Renaming hosts with careful hand,
From docs-dev to dev-docs bright,
And headers now sit just right!
Announcement bars? No overlap fear—
All changelog changes crystal clear! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description follows the required template structure but all content sections are empty; only the template placeholders and checklist items are present without actual information. Fill in 'What changed' with a sentence describing the header styling adjustment and deployment changes, and 'Why' with the reason or issue link prompting these changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adjusting header styling to prevent overlap with an announcement bar, which aligns with the primary CSS modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issues/keep-2ndDomain

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: lockfile failed supply-chain policy check. Run pnpm install locally to update the lockfile.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ditahkk ditahkk merged commit 863f1ac into main May 31, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants