Repository navigation
fix: cherry pick the fix for java21 encoding issue from V3 into V2 - #5034
Merged
Merged
Conversation
Signed-off-by: hrishikesh-nalawade <hrishikesh.nalawade.17@gmail.com> Signed-off-by: Hrishikesh Nalawade <167364362+hrishikesh-nalawade@users.noreply.github.com> Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com> (cherry picked from commit 0a636a4)
Signed-off-by: Ian Sergeant <ian.sergeant@broadcom.com> Signed-off-by: iansergeant42 <129340641+iansergeant42@users.noreply.github.com> Co-authored-by: Ian Sergeant <ian.sergeant@broadcom.com> (cherry picked from commit b76ff8a)
|
iansergeant42
requested changes
Oct 19, 2026
iansergeant42
left a comment
iansergeant42
left a comment
Contributor
There was a problem hiding this comment.
Along with what I've suggested, the following files are changed in #4659. I don't know for sure that they exist in v2 though:
apiml-utility/src/main/resources/logback-spring.xml
apiml-utility/src/test/resources/logback-test.xml
discoverable-client/src/main/resources/logback.xml
integration-tests/src/test/resources/logback.xml
onboarding-enabler-micronaut-sample-app/src/main/resources/logback.xml
scripts/test/start_test.bats
iansergeant42
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cherry pick below two PRs from V3 related to java21 encoding issue
#4659
#4482
Type of change
Checklist:
For more details about how should the code look like read the Contributing guideline