Skip to content

Cherry Pick Jafaral 63fd793 - #4

Open
Ian-Boraks wants to merge 1 commit into
zoompilot:mazda-devfrom
Ian-Boraks:zoompilot
Open

Cherry Pick Jafaral 63fd793#4
Ian-Boraks wants to merge 1 commit into
zoompilot:mazda-devfrom
Ian-Boraks:zoompilot

Conversation

@Ian-Boraks

Copy link
Copy Markdown

On Jafaral's custom Mazda forks, they have disabled the steer_required alert for newer Mazdas as they have the ability to steer down to zero.

From Jafaral on the comma.ai community discord (message link):

I chose to do alerts only when it actually make sense. When I added the official support, Comma requested to keep those alerts, so I kept/added them. However, there was so much unnecessary noise and I actually polled the users here and all requested no audiable alrers . . . and for the new CX-5, there is no practical reason to annoy the user when the car is driving at 0.000005 mph with no torque, who cares

I cherry picked their edits that appear in all of the custom Mazda branches. Here are a few examples:
https://github.com/Jafaral/openpilot/tree/mazda-eps22-swap-new/
https://github.com/Jafaral/openpilot/commits/mazda-0.9.9/
https://github.com/Jafaral/openpilot/commits/mazda-0.8.16

I decided not to cherry pick the edits to opendbc_repo/opendbc/car/mazda/interface.py:

- ret.dashcamOnly = candidate not in (CAR.MAZDA_CX5_2022, CAR.MAZDA_CX9_2021)
+ ret.dashcamOnly = False # candidate not in (CAR.MAZDA_CX5_2022, CAR.MAZDA_CX9_2021)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant