Cherry Pick Jafaral 63fd793 - #4
Open
Ian-Boraks wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Jafaral's custom Mazda forks, they have disabled the
steer_requiredalert for newer Mazdas as they have the ability to steer down to zero.From Jafaral on the comma.ai community discord (message link):
I cherry picked their edits that appear in all of the custom Mazda branches. Here are a few examples:
https://github.com/Jafaral/openpilot/tree/mazda-eps22-swap-new/
https://github.com/Jafaral/openpilot/commits/mazda-0.9.9/
https://github.com/Jafaral/openpilot/commits/mazda-0.8.16
I decided not to cherry pick the edits to
opendbc_repo/opendbc/car/mazda/interface.py: