Skip to content

Error on empty Over clause for MS SQL and SQLite #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denis-tsv wants to merge 2 commits into
base: master
Choose a base branch
from
+85 −2
Open

Error on empty Over clause for MS SQL and SQLite #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3003b65
Error on empty Over clause for MS SQL and SQLite
denis-tsv Mar 9, 2023
3763ce0
add tests
denis-tsv Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/Zomp.EFCore.WindowFunctions.Npgsql.Tests/RankTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,18 @@ public RankTests(ITestOutputHelper output)
[Fact]
public void RankBasic() => rankTests.RankBasic();

[Fact]
public void RankEmptyOver() => rankTests.RankEmptyOver();

[Fact]
public void DenseRankBasic() => rankTests.DenseRankBasic();

[Fact]
public void DenseRankEmptyOver() => rankTests.DenseRankEmptyOver();

[Fact]
public void PercentRankBasic() => rankTests.PercentRankBasic(true);

[Fact]
public void PercentRankEmptyOver() => rankTests.PercentRankEmptyOver(true);
}
14 changes: 13 additions & 1 deletion tests/Zomp.EFCore.WindowFunctions.SqlServer.Tests/RankTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,24 @@ public RankTests(ITestOutputHelper output)
[Fact]
public void RowNumberBasic() => rankTests.RowNumberBasic();

[Fact]
public void RowNumberEmptyOver() => rankTests.RowNumberEmptyOver();

[Fact]
public void RankBasic() => rankTests.RankBasic();

[Fact]
public void RankEmptyOver() => rankTests.RankEmptyOver();

[Fact]
public void DenseRankBasic() => rankTests.DenseRankBasic();

[Fact]
public void PercentRankBasic() => rankTests.PercentRankBasic();
public void DenseRankEmptyOver() => rankTests.DenseRankEmptyOver();

[Fact]
public void PercentRankBasic() => rankTests.PercentRankBasic(true);

[Fact]
public void PercentRankEmptyOver() => rankTests.PercentRankEmptyOver(true);
}
14 changes: 13 additions & 1 deletion tests/Zomp.EFCore.WindowFunctions.Sqlite.Tests/RankTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,24 @@ public RankTests(ITestOutputHelper output)
[Fact]
public void RowNumberBasic() => rankTests.RowNumberBasic();

[Fact]
public void RowNumberEmptyOver() => rankTests.RowNumberEmptyOver();

[Fact]
public void RankBasic() => rankTests.RankBasic();

[Fact]
public void RankEmptyOver() => rankTests.RankEmptyOver();

[Fact]
public void DenseRankBasic() => rankTests.DenseRankBasic();

[Fact]
public void PercentRankBasic() => rankTests.PercentRankBasic();
public void DenseRankEmptyOver() => rankTests.DenseRankEmptyOver();

[Fact]
public void PercentRankBasic() => rankTests.PercentRankBasic(true);

[Fact]
public void PercentRankEmptyOver() => rankTests.PercentRankEmptyOver(true);
}
50 changes: 50 additions & 0 deletions tests/Zomp.EFCore.WindowFunctions.Testing/RankTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,23 @@ public void RankBasic()
Assert.Equal(expectedSequence, result.Select(r => r.Rank));
}

public void RankEmptyOver()
{
var query = dbContext.TestRows
.Select(r => new
{
Rank = EF.Functions.Rank(EF.Functions.Over()),
});

var result = query.ToList();

var expectedSequence = TestFixture.TestRows
.Select((r, i) => 1L)
.ToList();

Assert.Equal(expectedSequence, result.Select(r => r.Rank));
}

public void DenseRankBasic()
{
var query = dbContext.TestRows
Expand All @@ -80,6 +97,22 @@ public void DenseRankBasic()
Assert.Equal(expectedSequence, result.Select(r => r.DenseRank));
}

public void DenseRankEmptyOver()
{
var query = dbContext.TestRows
.Select(r => new
{
DenseRank = EF.Functions.DenseRank(EF.Functions.Over()),
});

var result = query.ToList();

var expectedSequence = TestFixture.TestRows
.Select((r, i) => 1L);

Assert.Equal(expectedSequence, result.Select(r => r.DenseRank));
}

public void PercentRankBasic(bool nullsLast = false)
{
var query = dbContext.TestRows
Expand All @@ -104,4 +137,21 @@ public void PercentRankBasic(bool nullsLast = false)

Assert.Equal(expectedSequence, result.Select(r => r.PercentRank));
}

public void PercentRankEmptyOver(bool nullsLast = false)
{
var query = dbContext.TestRows
.Select(r => new
{
PercentRank = EF.Functions.PercentRank(EF.Functions.Over()),
});

var result = query.ToList();

var expectedSequence = TestFixture.TestRows
.Select(r => 0d)
.ToList();

Assert.Equal(expectedSequence, result.Select(r => r.PercentRank));
}
}