Skip VAAPI hwcontext bindings on Windows - #134
Open
inayayousfi wants to merge 1 commit into
Open
inayayousfi wants to merge 1 commit into
inayayousfi wants to merge 1 commit into
Conversation
inayayousfi directed the work and made every decision. openai/gpt-5.6-sol, running in OpenCode, carried inayayousfi's decisions out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inayayousfi directed the work and made every decision.
openai/gpt-5.6-sol, running in OpenCode, carried inayayousfi's decisions out.
hwcontext_wrapper.hincludes the VAAPI hardware context whenever the FFmpeg header is installed. A Windows vcpkg FFmpeg package can providehwcontext_vaapi.hwithout its Linux-onlyva/va_x11.hdependency, so bindgen fails while parsing a hardware API that Windows cannot use.Skip the VAAPI wrapper when
_WIN32is defined. The D3D11VA and D3D12VA bindings remain enabled.Tested by preprocessing the wrapper with
_WIN32defined and the same stub include path used by the build script. The same change also builds downstream on x86_64-pc-windows-msvc with static FFmpeg 8.1.2 from vcpkg.