Skip to content

feat: support nullable external id mapping#1672

Closed
marcelo-cjl wants to merge 1 commit into
mainfrom
codex/nullable-external-id-map
Closed

feat: support nullable external id mapping#1672
marcelo-cjl wants to merge 1 commit into
mainfrom
codex/nullable-external-id-map

Conversation

@marcelo-cjl

Copy link
Copy Markdown
Collaborator

Summary

  • Add ExternalIdMap to centralize nullable and relayout id mapping.
  • Wire mapped filtering and one-pass result id mapping across Knowhere index nodes, brute force, iterators, and vector retrieval paths.
  • Add nullable external id map unit coverage.

Test plan

  • git diff --check HEAD~1..HEAD
  • Full compile/tests not rerun in this PR creation step.

Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcelo-cjl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Jun 10, 2026

Copy link
Copy Markdown

@marcelo-cjl 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@marcelo-cjl

Copy link
Copy Markdown
Collaborator Author

Closed in favor of fork-based PR #1673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants