Align MTORR concentrator constants with Silicon Labs SDK defaults#718
Draft
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Draft
Align MTORR concentrator constants with Silicon Labs SDK defaults#718TheJulianJES wants to merge 1 commit intozigpy:devfrom
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Conversation
The current values were inherited from very old EmberZNet sample code and don't match what the Silicon Labs SDK or other modern adapters use: | Param | Old | New | SDK default | SDK range | |-----------------------------|-------|-----|-------------|-----------| | MTOR_MIN_INTERVAL | 60 | 10 | 10 | 1..60 | | MTOR_MAX_INTERVAL | 3600 | 60 | 60 | 30..300 | | MTOR_ROUTE_ERROR_THRESHOLD | 8 | 3 | 3 | 1..100 | | MTOR_DELIVERY_FAIL_THRESHOLD| 8 | 1 | 1 | 1..100 | `MTOR_MAX_INTERVAL = 3600` was the worst of the four — 12× the SDK documented maximum. The NCP accepted it on the wire (uint16) but it meant up to an hour between MTORR broadcasts, leaving devices that lost their route to the concentrator stranded for that long. The higher error/failure thresholds also slowed reactive re-broadcasts on topology changes. The SDK plugin defaults are documented in `protocol/zigbee/app/framework/plugin/concentrator/config/concentrator-config.h`. zigbee-herdsman's ember adapter applies the same defaults and validates against the same ranges.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #718 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 61 61
Lines 4147 4147
=======================================
Hits 4128 4128
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT: Check if this is really accurate.
AI summary (check if accurate)
The current values were inherited from very old EmberZNet sample code and don't match what the Silicon Labs SDK or other modern adapters use:
MTOR_MAX_INTERVAL = 3600was the worst of the four — 12× the SDK documented maximum. The NCP accepted it on the wire (uint16) but it meant up to an hour between MTORR broadcasts, leaving devices that lost their route to the concentrator stranded for that long. The higher error/failure thresholds also slowed reactive re-broadcasts on topology changes.The SDK plugin defaults are documented in
protocol/zigbee/app/framework/plugin/concentrator/config/concentrator-config.h. zigbee-herdsman's ember adapter applies the same defaults and validates against the same ranges.