Skip to content

Show error in Actions summary for safety issues in normal/scheduled runs#2138

Open
andy-maier wants to merge 2 commits intomasterfrom
andy/safety-warning
Open

Show error in Actions summary for safety issues in normal/scheduled runs#2138
andy-maier wants to merge 2 commits intomasterfrom
andy/safety-warning

Conversation

@andy-maier
Copy link
Copy Markdown
Member

@andy-maier andy-maier commented Apr 12, 2026

For details, see the commit message.

Note: This PR is on top of PR #2139 - merge only after that one is merged

@andy-maier andy-maier self-assigned this Apr 12, 2026
@andy-maier andy-maier added this to the 1.26.0 milestone Apr 12, 2026
@andy-maier andy-maier changed the title Show error in Actions summary for safety issues in normal/schedules runs Show error in Actions summary for safety issues in normal/scheduled runs Apr 12, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 12, 2026

Coverage Status

coverage: 77.19%. remained the same — andy/safety-warning into master

@andy-maier andy-maier force-pushed the andy/safety-warning branch 8 times, most recently from dfbffa4 to 197df15 Compare April 12, 2026 13:41
…mands

Details:

* Dev: Using bash as the make shell on Windows. This allows cleaning up all
  the conditional processing for Windows-specific commands and the use of
  "bash -c".

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier andy-maier force-pushed the andy/safety-warning branch from 197df15 to ad48e4c Compare April 12, 2026 15:41
Details:

* Safety issues that are detected in normal and scheduled Actions runs
  now cause an error to be shown in the Actions summary. They still
  (intentionally) do not cause the Actions run to fail. Note that safety issues
  detected during an Actions release run, or during local use, do cause the
  make command and Actions run to fail.

* In addition, the safety command is now always run for both development
  and install before checking for failure.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants